LinuxKPI: add default_gfp()
ClosedPublic
Actions

Authored by bz on Tue, Apr 14, 3:32 PM.

Details

Reviewers

dumbbell

Group Reviewers

linuxkpi

Commits

rGd73d7776b508: LinuxKPI: add default_gfp()
rG35b90c21f480: LinuxKPI: add default_gfp()

Summary

Various new allocation macros can take an optional gfp_t argument.
If the argument is not given we need to set the GFP_KERNEL default.
While this is only internally used and I initialy called it differently,
should this spread elsewhere having the same name as in Linux will be
good.

Sponsored by: The FreeBSD Foundaton
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 72244
Build 69127: arc lint + arc unit

Event Timeline

bz created this revision.Tue, Apr 14, 3:32 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptTue, Apr 14, 3:32 PM

bz requested review of this revision.Tue, Apr 14, 3:32 PM

Harbormaster completed remote builds in B72201: Diff 175508.Tue, Apr 14, 3:32 PM

bz added a parent revision: D56391: LinuxKPI: move hex2bin() from kernel.h to new hex.h.Tue, Apr 14, 3:36 PM

bz added a child revision: D56393: LinuxKPI: conditionally add __flex_counter().

Why name it __lkpi_default_gfp() and not __default_gfp() like Linux? I'm sure some drivers will use it if it's available :)

In D56392#1291580, @dumbbell wrote:

Why name it __lkpi_default_gfp() and not __default_gfp() like Linux? I'm sure some drivers will use it if it's available :)

I would hope not.

I don't know the name of that thing in Linux either. I just prefixed it with lkpi for the internal part not supposed to be public KPI and added __ given it's macro.
I was silly enough initially to only use ``(_arg_or_default, ...) without the _discard only to be reminded that that gives you errors if you do not pass an argument in given ##VA_ARGS works on the "trailing" comma.

I'll rename it if that's easier.

Ranme "internal" part of the function to __default_gfp as suggested by @dumbbell to match Linux.

Harbormaster completed remote builds in B72244: Diff 175605.Wed, Apr 15, 9:56 PM

I agree it looks like a private API and I also hope it's not used. But I already saw functions and macros starting with underscores being used anyway...

This revision is now accepted and ready to land.Thu, Apr 16, 7:43 PM

Closed by commit rG35b90c21f480: LinuxKPI: add default_gfp() (authored by bz). · Explain WhySat, Apr 18, 1:13 AM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG35b90c21f480: LinuxKPI: add default_gfp().

bz added a commit: rGd73d7776b508: LinuxKPI: add default_gfp().Wed, Apr 22, 9:13 PM