tests/fusefs: appease gcc -Wcast-qual
ClosedPublic
Actions

Authored by rlibby on Apr 13 2026, 2:02 AM.

Details

Reviewers

asomers
kib

Commits

rG7a2de8121a2f: tests/fusefs: appease gcc -Wcast-qual
rG0c09c6527b16: tests/fusefs: appease gcc -Wcast-qual

Summary

Fix gcc build error.

Fixes: 7e68af7ce2c1 ("fusefs: redo vnode attribute locking")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 72166
Build 69049: arc lint + arc unit

Event Timeline

rlibby created this revision.Apr 13 2026, 2:02 AM

Herald added subscribers: asomers, imp. · View Herald TranscriptApr 13 2026, 2:02 AM

rlibby requested review of this revision.Apr 13 2026, 2:02 AM

Harbormaster completed remote builds in B72166: Diff 175396.Apr 13 2026, 2:02 AM

rlibby added a reviewer: asomers.Apr 13 2026, 2:03 AM

rlibby added a reviewer: kib.Apr 15 2026, 9:30 AM

kib accepted this revision.Apr 15 2026, 9:41 AM

This revision is now accepted and ready to land.Apr 15 2026, 9:41 AM

Instead of relying on casting, how about we fix the problem more robustly, like this?

diff --git a/tests/sys/fs/fusefs/rename.cc b/tests/sys/fs/fusefs/rename.cc
index 385f26953aae..ae57469f2665 100644
--- a/tests/sys/fs/fusefs/rename.cc
+++ b/tests/sys/fs/fusefs/rename.cc
@@ -166,7 +166,7 @@ TEST_F(Rename, entry_cache_negative_purge)
 static volatile int stopit = 0;
 
 static void* setattr_th(void* arg) {
-       char *path = (char*)arg;
+       const char *path = *(const char**)arg;
 
        while (stopit == 0)
                 chmod(path, 0777);
@@ -239,7 +239,7 @@ TEST_F(Rename, erelookup)
                _)
        ).WillRepeatedly(Invoke(ReturnErrno(EIO)));
 
-       ASSERT_EQ(0, pthread_create(&th0, NULL, setattr_th, (void*)FULLSRC))
+       ASSERT_EQ(0, pthread_create(&th0, NULL, setattr_th, (void*)&FULLSRC))
                << strerror(errno);
 
        ASSERT_EQ(0, clock_gettime(CLOCK_MONOTONIC, &timeout));

This revision now requires changes to proceed.Apr 15 2026, 12:58 PM

In D56370#1291214, @asomers wrote:

-       ASSERT_EQ(0, pthread_create(&th0, NULL, setattr_th, (void*)FULLSRC))
+       ASSERT_EQ(0, pthread_create(&th0, NULL, setattr_th, (void*)&FULLSRC))
                << strerror(errno);

This leads to essentially the same complaint from gcc:

/usr/src/freebsd/tests/sys/fs/fusefs/rename.cc:242:61: error: cast from type 'const char (*)[15]' to type 'void*' casts away qualifiers [-Werror=cast-qual]
  242 |         ASSERT_EQ(0, pthread_create(&th0, NULL, setattr_th, (void*)&FULLSRC))
      |                                                             ^~~~~~~~~~~~~~~

Ooh pooh. I guess you should do it your way, then.

This revision is now accepted and ready to land.Apr 15 2026, 4:01 PM

Closed by commit rG0c09c6527b16: tests/fusefs: appease gcc -Wcast-qual (authored by rlibby). · Explain WhyApr 15 2026, 4:35 PM

This revision was automatically updated to reflect the committed changes.

rlibby added a commit: rG0c09c6527b16: tests/fusefs: appease gcc -Wcast-qual.

jhb added a commit: rG7a2de8121a2f: tests/fusefs: appease gcc -Wcast-qual.Apr 24 2026, 3:30 PM