Page MenuHomeFreeBSD
Differential D56151

rtld: check for overflow in parse_integer()
ClosedPublic
Actions

Authored by kib on Sun, Mar 29, 11:09 PM.

Details

Reviewers
dim
emaste
markj
Commits
rG7cfffe25da3f: rtld: check for overflow in parse_integer()

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib created this revision.Sun, Mar 29, 11:09 PM
Herald added subscribers: bdragon, imp. · View Herald TranscriptSun, Mar 29, 11:09 PM
kib requested review of this revision.Sun, Mar 29, 11:09 PM
dim added a comment.Mon, Mar 30, 11:48 AM

LGTM

markj added inline comments.Mon, Mar 30, 11:58 AM
libexec/rtld-elf/rtld.c
6507

Can we use the stdckint.h routines instead? There is no libc dependency there.

dim added inline comments.Mon, Mar 30, 12:12 PM
libexec/rtld-elf/rtld.c
6507

Can we use the stdckint.h routines instead? There is no libc dependency there.

You can also avoid the need for wrapping, and avoid unsigned ints, like so:

if (n > INT_MAX / 10)
  return (-1);
n *= 10;
if (n > INT_MAX - (c - '\0'))
  return (-1);
n += (c - '\0');

No need for stdckint.h then, either.

kib updated this revision to Diff 174528.Mon, Mar 30, 12:19 PM
kib marked 2 inline comments as done.

Take Dimitry suggestion.

markj accepted this revision.Mon, Mar 30, 12:21 PM
This revision is now accepted and ready to land.Mon, Mar 30, 12:21 PM
dim accepted this revision.Mon, Mar 30, 12:21 PM

LGTM again :)

emaste accepted this revision.Mon, Mar 30, 3:20 PM
Closed by commit rG7cfffe25da3f: rtld: check for overflow in parse_integer() (authored by kib). · Explain WhyMon, Mar 30, 5:16 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG7cfffe25da3f: rtld: check for overflow in parse_integer().

Revision Contents
Changeset List

PathSize
libexec/
rtld-elf/
4 lines

Diff 174528

View Options

libexec/rtld-elf/rtld.c

Loading...