Page MenuHomeFreeBSD

diff3: prefer posix_spawn over pdfork/execlp
ClosedPublic

Authored by bapt on Wed, Mar 25, 10:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 31, 8:42 PM
Unknown Object (File)
Tue, Mar 31, 3:27 AM
Unknown Object (File)
Mon, Mar 30, 5:40 AM
Unknown Object (File)
Mon, Mar 30, 5:40 AM
Unknown Object (File)
Mon, Mar 30, 1:34 AM
Unknown Object (File)
Mon, Mar 30, 12:28 AM
Unknown Object (File)
Sun, Mar 29, 3:00 PM
Unknown Object (File)
Sun, Mar 29, 10:02 AM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71706
Build 68589: arc lint + arc unit

Event Timeline

bapt requested review of this revision.Wed, Mar 25, 10:09 AM

Unrelated note: it seems that pipe fds leak to both pd13 and pd23 processes. This is perhaps not too important but just not accurate. And since we care about 'security' by entering cap mode, ability of the children to affect input of siblings or parent might be considered undesirable.

usr.bin/diff3/diff3.c
1092

Spurious blank line

This revision is now accepted and ready to land.Wed, Mar 25, 9:57 PM
This revision was automatically updated to reflect the committed changes.