tcp_usrreq: allocate tfo counter when required
ClosedPublic
Actions

Authored by pouria on Mar 24 2026, 5:58 PM.

Details

Reviewers

tuexen
rscheff
glebius

Group Reviewers

transport

Commits

rG769a6f803d1b: tcp_usrreq: Only allocate TFO counter when required

Summary

During tcp_usr_listen, only allocate tfo when required.

Test Plan

Run network tests:

kyua test -k /usr/tests/Kyuafile sys/netinet

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 71694
Build 68577: arc lint + arc unit

Event Timeline

pouria created this revision.Mar 24 2026, 5:58 PM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptMar 24 2026, 5:58 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

pouria requested review of this revision.Mar 24 2026, 5:58 PM

Harbormaster completed remote builds in B71694: Diff 174242.Mar 24 2026, 5:58 PM

Do the same for tcp6_usr_listen()

Harbormaster completed remote builds in B71695: Diff 174243.Mar 24 2026, 6:15 PM

tuexen added inline comments.Mar 24 2026, 8:42 PM

sys/netinet/tcp_usrreq.c
469	You can now use an else clause here.

Address @tuexen comment.

Harbormaster completed remote builds in B71696: Diff 174245.Mar 24 2026, 8:45 PM

tuexen accepted this revision.Mar 24 2026, 9:26 PM

This revision is now accepted and ready to land.Mar 24 2026, 9:26 PM

glebius accepted this revision.Mar 24 2026, 9:51 PM

Closed by commit rG769a6f803d1b: tcp_usrreq: Only allocate TFO counter when required (authored by pouria). · Explain WhyMar 24 2026, 10:04 PM

This revision was automatically updated to reflect the committed changes.

pouria added a commit: rG769a6f803d1b: tcp_usrreq: Only allocate TFO counter when required.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_usrreq.c

7 lines

Diff 174242

View Options

tcp_usrreq: allocate tfo counter when requiredClosedPublicActions