Page MenuHomeFreeBSD
Differential D55941

sound: Do not create root feeder in chn_init()
ClosedPublic
Actions

Authored by christos on Mar 19 2026, 3:16 PM.
Tags
None
Referenced Files
F167958440: D55941.id.diff
Tue, Aug 25, 3:23 PM
Unknown Object (File)
Tue, Aug 25, 5:17 AM
Unknown Object (File)
Sun, Aug 23, 3:44 AM
Unknown Object (File)
Sun, Aug 23, 3:32 AM
Unknown Object (File)
Fri, Aug 21, 11:02 AM
Unknown Object (File)
Fri, Aug 21, 3:34 AM
Unknown Object (File)
Thu, Aug 20, 11:09 AM
Unknown Object (File)
Wed, Aug 19, 3:46 AM
View All 79 Files
Subscribers
imp

Details

Reviewers
markj
emaste
Commits
rG7c483aa01363: sound: Do not create root feeder in chn_init()
rGb9f9fc473eb5: sound: Do not create root feeder in chn_init()
Summary

The feeder chain gets destroyed when feeder_chain() is called, which is
after the chn_reset() call in chn_init() further down for primary chans,
or vchan_create() for vchans. This makes the root feeder creation in
chn_init() essentially a no-op. Remove it altogether and let
feeder_chain() after chn_reset() take care of creating the feeder
properly. It creates the root one as well.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
12 lines

Diff 174218

View Options

sys/dev/sound/pcm/channel.c

Loading...