Differential D55818

nvme: replace bus_space_[read|write]_4 with bus_[read|write]_4
ClosedPublic
Actions

Authored by ziaee on Wed, Mar 11, 8:55 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Mar 30, 4:48 AM

	Unknown Object (File)
	Sun, Mar 29, 11:56 PM

	Unknown Object (File)
	Sun, Mar 29, 2:21 AM

	Unknown Object (File)
	Sat, Mar 28, 11:21 AM

	Unknown Object (File)
	Wed, Mar 25, 5:57 PM

	Unknown Object (File)
	Sat, Mar 21, 10:31 PM

	Unknown Object (File)
	Sat, Mar 21, 5:01 AM

	Unknown Object (File)
	Sat, Mar 21, 5:01 AM

View All 16 Files

Subscribers

Details

Reviewers

jhb
imp
jrtc27
gallatin

Commits

rG889d10d5b120: nvme: Replace bus_space_[read|write]_4 with bus_[read|write]_4

Summary

The goal this change is to remove the use of the tag and handle
needed by bus_space_[read|write]_4.

Proxying on behalf of Matt Delco <delco@google.com>
Requested by: jhb

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 71352
Build 68235: arc lint + arc unit

Event Timeline

ziaee created this revision.Wed, Mar 11, 8:55 PM

Herald added a subscriber: dab. · View Herald TranscriptWed, Mar 11, 8:55 PM

ziaee requested review of this revision.Wed, Mar 11, 8:55 PM

Harbormaster completed remote builds in B71352: Diff 173589.Wed, Mar 11, 8:55 PM

ziaee added a parent revision: D55817: nvme: removed unused 'regs' variable.Wed, Mar 11, 8:58 PM

ziaee edited the summary of this revision. (Show Details)

ziaee edited the summary of this revision. (Show Details)

imp accepted this revision.Wed, Mar 11, 9:26 PM

This revision is now accepted and ready to land.Wed, Mar 11, 9:26 PM

gallatin accepted this revision.Wed, Mar 11, 9:44 PM

jrtc27 added inline comments.Wed, Mar 11, 10:15 PM

sys/dev/nvme/nvme_private.h
328–343	Worth reformatting the code as part of it given they now fit on fewer lines, and whilst here, can fix the missing spaces around +, and the missing parentheses around val for nvme_mmio_write_8

jrtc27 added inline comments.Wed, Mar 11, 10:19 PM

sys/dev/nvme/nvme_private.h
328–343	(Phabricator mangles the whitespace, but an editor that visually distinguishes between tabs and spaces, and has a tab width of 8, should make it clear)

When committing, you can just use Matt's name as the commit author (you will still be the committer). I agree with Jess on reformatting the macros.

Attempt to improve whitespace. I'm not sure if I'm understanding @jrtc27's whitespace suggestion but also I've never done this part of it before.

When committing, you can just use Matt's name as the commit author (you will still be the committer). I agree with Jess on reformatting the macros.

Of course. Please note I merged over a hundred contributor reviews and believe I have never messed this up. I did however once misattribute emaste to having reviewed something that he did not, which still stings, though I do not believe he held it against me.

Thanks so much for helping with this!

This revision now requires review to proceed.Sat, Mar 14, 6:27 PM

Harbormaster completed remote builds in B71403: Diff 173697.Sat, Mar 14, 6:27 PM

One tiny missing space, otherwise LGTM, feel free to fix on commit

sys/dev/nvme/nvme_private.h
334

This revision is now accepted and ready to land.Sat, Mar 14, 9:37 PM

Closed by commit rG889d10d5b120: nvme: Replace bus_space_[read|write]_4 with bus_[read|write]_4 (authored by Matt Delco <delco@google.com>, committed by ziaee). · Explain WhyMon, Mar 16, 7:45 PM

This revision was automatically updated to reflect the committed changes.

ziaee added a commit: rG889d10d5b120: nvme: Replace bus_space_[read|write]_4 with bus_[read|write]_4.

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvme/

2 lines

3 lines

10 lines

7 lines

Diff 173589

sys/dev/nvme/nvme_ahci.c

Loading...

sys/dev/nvme/nvme_pci.c

Loading...

sys/dev/nvme/nvme_private.h

Loading...

sys/dev/nvme/nvme_qpair.c

Loading...