Page MenuHomeFreeBSD
Differential D55817

nvme: removed unused 'regs' variable
ClosedPublic
Actions

Authored by ziaee on Wed, Mar 11, 8:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 29, 11:56 PM
Unknown Object (File)
Fri, Mar 27, 8:26 PM
Unknown Object (File)
Fri, Mar 27, 6:05 AM
Unknown Object (File)
Wed, Mar 25, 5:56 AM
Unknown Object (File)
Wed, Mar 25, 2:45 AM
Unknown Object (File)
Tue, Mar 24, 9:57 PM
Unknown Object (File)
Sun, Mar 22, 4:07 PM
Unknown Object (File)
Sat, Mar 21, 12:25 PM
View All 11 Files
Subscribers
dab

Details

Reviewers
jhb
imp
jrtc27
gallatin
Commits
rG4e3beef84628: nvme: Removed unused 'regs' variable
Summary

The private struct has a 'regs' member that's only written to
and otherwise unused. This change removes it.

Proxying on behalf of Matt Delco <delco@google.com>

Requested by: jhb

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71351
Build 68234: arc lint + arc unit

Event Timeline

ziaee created this revision.Wed, Mar 11, 8:54 PM
Herald added a subscriber: dab. · View Herald TranscriptWed, Mar 11, 8:54 PM
ziaee requested review of this revision.Wed, Mar 11, 8:54 PM
Harbormaster completed remote builds in B71351: Diff 173588.Wed, Mar 11, 8:55 PM
ziaee added a child revision: D55818: nvme: replace bus_space_[read|write]_4 with bus_[read|write]_4.Wed, Mar 11, 8:58 PM
ziaee edited the summary of this revision. (Show Details)
imp accepted this revision.Wed, Mar 11, 9:25 PM

Yes. We only use struct nvme_registers for register offsets, and otherwise use bus space to get the data.

This revision is now accepted and ready to land.Wed, Mar 11, 9:25 PM
jrtc27 accepted this revision.Wed, Mar 11, 10:17 PM
jhb accepted this revision.Thu, Mar 12, 3:12 PM

Great that we already use bus_space. I feared the worst when I saw this assignment fly by in the earlier diff.

Closed by commit rG4e3beef84628: nvme: Removed unused 'regs' variable (authored by Matt Delco <delco@google.com>, committed by ziaee). · Explain WhyMon, Mar 16, 7:45 PM
This revision was automatically updated to reflect the committed changes.
ziaee added a commit: rG4e3beef84628: nvme: Removed unused 'regs' variable.

Revision Contents
Changeset List

PathSize
sys/
dev/
nvme/
1 line
1 line
2 lines

Diff 173588

View Options

sys/dev/nvme/nvme_ahci.c

Loading...
View Options

sys/dev/nvme/nvme_pci.c

Loading...
View Options

sys/dev/nvme/nvme_private.h

Loading...