netlink: Fix expire column in -r flag using netlink
ClosedPublic
Actions

Authored by pouria on Sun, Feb 22, 4:55 PM.

Details

Reviewers

glebius
melifaro
zlei
markj

Group Reviewers

network

Commits

rG2f7cfeebcc43: netstat(1): Fix expire column in -r flag using netlink

Summary

netstat expire time report broken since netlink

Test Plan

I was going to write a test command for it,
but then I found out that route(8) on netlink is broken too. :)
use route compiled WITHOUT_NETLINK_SUPPORT for now.

route -n6 add -host 3fff::1 -gateway ::1 -expire +10
netstat -rn6

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 70996
Build 67879: arc lint + arc unit

Event Timeline

pouria created this revision.Sun, Feb 22, 4:55 PM

Herald added a subscriber: imp. · View Herald TranscriptSun, Feb 22, 4:55 PM

pouria requested review of this revision.Sun, Feb 22, 4:55 PM

Harbormaster completed remote builds in B70880: Diff 172449.Sun, Feb 22, 4:55 PM

pouria mentioned this in D55444: route: Fix -expire argument when using netlink.Sun, Feb 22, 6:45 PM

Fix multipath expire values too.

pouria added a parent revision: D55442: rtnetlink: Add support for nexthop expiration in new route.Wed, Feb 25, 4:39 PM

glebius accepted this revision as: glebius.Thu, Feb 26, 3:18 AM

This revision is now accepted and ready to land.Thu, Feb 26, 3:18 AM

This revision was landed with ongoing or failed builds.Thu, Feb 26, 12:35 PM

Closed by commit rG2f7cfeebcc43: netstat(1): Fix expire column in -r flag using netlink (authored by pouria). · Explain Why

This revision was automatically updated to reflect the committed changes.

pouria added a commit: rG2f7cfeebcc43: netstat(1): Fix expire column in -r flag using netlink.

Revision Contents
Changeset List

Path

Size

usr.bin/

netstat/

route_netlink.c

5 lines

Diff 172688

View Options

usr.bin/netstat/route_netlink.c

netlink: Fix expire column in -r flag using netlinkClosedPublicActions