loader.efi: tss_pa setup seems to be flawed in trap.c
ClosedPublic
Actions

Authored by tsoome on Sun, Feb 8, 11:01 AM.

Details

Reviewers

manu
kib

Commits

rGdc11af08a498: loader.efi: tss_pa setup seems to be flawed in trap.c

Summary

since sd_lobase is 24 bits, we would need to shift 24 bits, not 16.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70848
Build 67731: arc lint + arc unit

Event Timeline

tsoome created this revision.Sun, Feb 8, 11:01 AM

Herald added a reviewer: manu. · View Herald TranscriptSun, Feb 8, 11:01 AM

Herald added subscribers: dab, bcran, imp. · View Herald Transcript

tsoome requested review of this revision.Sun, Feb 8, 11:01 AM

tsoome added a parent revision: D55177: fix typo in efi/loader/arch/amd64/trap.c.

Harbormaster completed remote builds in B70516: Diff 171446.Sun, Feb 8, 11:01 AM

tsoome added a child revision: D55179: loader.efi: free_tables() appears to free tss_pa twice..Sun, Feb 8, 11:02 AM

kib accepted this revision.Sun, Feb 8, 12:02 PM

kib added a subscriber: kib.

kib added inline comments.

stand/efi/loader/arch/amd64/trap.c
223	sd_lobase is 24-bits wide, so I do not think it matters

This revision is now accepted and ready to land.Sun, Feb 8, 12:02 PM

tsoome marked an inline comment as done.Sat, Feb 21, 8:48 AM

tsoome added inline comments.

stand/efi/loader/arch/amd64/trap.c
223	yep, dropping it.

remove not needed mask.

This revision now requires review to proceed.Sat, Feb 21, 8:49 AM

Harbormaster completed remote builds in B70848: Diff 172370.Sat, Feb 21, 8:49 AM

This revision was not accepted when it landed; it landed in state Needs Review.Sat, Feb 21, 8:56 AM

Closed by commit rGdc11af08a498: loader.efi: tss_pa setup seems to be flawed in trap.c (authored by tsoome). · Explain Why

This revision was automatically updated to reflect the committed changes.

tsoome added a commit: rGdc11af08a498: loader.efi: tss_pa setup seems to be flawed in trap.c.

Revision Contents
Changeset List

Path

Size

stand/

efi/

loader/

arch/

amd64/

trap.c

2 lines

Diff 172370

View Options

stand/efi/loader/arch/amd64/trap.c

loader.efi: tss_pa setup seems to be flawed in trap.cClosedPublicActions