rge: log silicon revision during attach
ClosedPublic
Actions

Authored by chris.longros_gmail.com on Fri, Feb 20, 4:20 PM.

Details

Reviewers

adrian
imp
zlei

Group Reviewers

network

Commits

rGacbf7498f5e1: rge: log silicon revision during attach

Summary

The initial import from OpenBSD contained chip revision printf() calls
commented out, as OpenBSD's bare printf() style does not translate to
FreeBSD's device_printf() idiom. The result is that users cannot
distinguish RTL8125 from RTL8125B, RTL8125D_1, RTL8125D_2 etc. via
dmesg alone, even though all variants show as '<RTL8125>' from the PCI
probe string.

Add proper device_printf() calls including the raw hwrev value,
consistent with how re(4) reports chip revisions.

Signed-off-by: Christos Longros <chris.longros@gmail.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70823
Build 67706: arc lint + arc unit

Event Timeline

chris.longros_gmail.com created this revision.Fri, Feb 20, 4:20 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Feb 20, 4:20 PM

chris.longros_gmail.com requested review of this revision.Fri, Feb 20, 4:20 PM

Harbormaster completed remote builds in B70823: Diff 172320.Fri, Feb 20, 4:20 PM

chris.longros_gmail.com added a reviewer: adrian.Fri, Feb 20, 4:26 PM

This originated in https://github.com/freebsd/freebsd-src/pull/2036 which I closed since Adrian said he'd take it from here. Document that.
Also, seems legit, though it would be cool if we had this info as a sysctl hanging of the newbus sysctl nodes... Though that expands the scope too much...

This revision is now accepted and ready to land.Sat, Feb 21, 3:20 PM

adrian added a parent revision: D55420: rge: correctly free busdma memory / zero things out only if allocated.Sat, Feb 21, 7:45 PM

adrian accepted this revision.Sat, Feb 21, 8:07 PM

adrian added a reviewer: network.

adrian added a project: network.

adrian accepted this revision.Sun, Feb 22, 2:33 AM