Page MenuHomeFreeBSD
Differential D55367

icmp6: Remove csum_flags on mbuf reused for ICMP message
ClosedPublic
Actions

Authored by timo.voelker_fh-muenster.de on Thu, Feb 19, 12:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 23, 9:54 PM
Unknown Object (File)
Mon, Feb 23, 1:16 AM
Unknown Object (File)
Sun, Feb 22, 9:02 PM
Unknown Object (File)
Sun, Feb 22, 7:30 PM
Unknown Object (File)
Fri, Feb 20, 9:34 PM
Unknown Object (File)
Fri, Feb 20, 11:11 AM
Unknown Object (File)
Fri, Feb 20, 5:44 AM
Subscribers
ae
imp
zlei

Details

Reviewers
glebius
tuexen
kp
melifaro
zlei
Commits
rGea75f726c432: icmp6: clear csum_flags on mbuf reuse
rG28b5b653a567: icmp6: clear csum_flags on mbuf reuse
rG0a87ae18331d: icmp6: clear csum_flags on mbuf reuse
rGada4dc77577f: icmp6: clear csum_flags on mbuf reuse
Summary

When icmp6 sends an ICMPv6 message, it reuses the mbuf of the packet that triggered the ICMPv6 message and prepends an IP and ICMPv6 header. For a locally generated packet with checksum offloading, the mbuf still has csum_flags set indicating that a SCTP/TCP/UDP checksum has to be computed and inserted. Since this not the case anymore, csum_flags need to be removed.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

timo.voelker_fh-muenster.de created this revision.Thu, Feb 19, 12:15 PM
Herald added subscribers: ae, imp. · View Herald TranscriptThu, Feb 19, 12:15 PM
timo.voelker_fh-muenster.de requested review of this revision.Thu, Feb 19, 12:15 PM

Solves this bug:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=293227

kp accepted this revision.Thu, Feb 19, 12:47 PM

(Not tested, but that just seems sensible.)

This revision is now accepted and ready to land.Thu, Feb 19, 12:47 PM
tuexen accepted this revision.Thu, Feb 19, 1:05 PM
zlei accepted this revision.Thu, Feb 19, 2:09 PM
zlei added a subscriber: zlei.

Looks good to me.

Closed by commit rGada4dc77577f: icmp6: clear csum_flags on mbuf reuse (authored by timo.voelker_fh-muenster.de, committed by tuexen). · Explain WhyThu, Feb 19, 2:21 PM
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rGada4dc77577f: icmp6: clear csum_flags on mbuf reuse.
tuexen added a commit: rG0a87ae18331d: icmp6: clear csum_flags on mbuf reuse.Thu, Feb 19, 6:58 PM
cperciva added a commit: rG28b5b653a567: icmp6: clear csum_flags on mbuf reuse.Thu, Feb 19, 7:28 PM
tuexen added a commit: rGea75f726c432: icmp6: clear csum_flags on mbuf reuse.Sun, Feb 22, 9:48 AM

Revision Contents
Changeset List

PathSize
sys/
netinet6/
1 line

Diff 172231

View Options

sys/netinet6/icmp6.c

Loading...