Page MenuHomeFreeBSD
Differential D54960

virtio_blk: Use bus_dma for command/ack buffer allocations
Needs ReviewPublic
Actions

Authored by sarah.walker2_arm.com on Fri, Jan 30, 11:14 AM.
Tags
None
Referenced Files
F145746618: D54960.diff
Mon, Feb 23, 9:54 PM
Unknown Object (File)
Fri, Feb 20, 3:46 PM
Unknown Object (File)
Thu, Feb 19, 7:27 PM
Unknown Object (File)
Wed, Feb 18, 9:55 AM
Unknown Object (File)
Wed, Feb 18, 3:14 AM
Unknown Object (File)
Sun, Feb 15, 3:52 AM
Unknown Object (File)
Thu, Feb 5, 4:29 PM
Unknown Object (File)
Sat, Jan 31, 3:15 AM
View All 12 Files
Subscribers
br
imp

Details

Reviewers
bryanv
andrew
Summary

While the majority of virtio platforms will be fully coherent, some may
require cache maintenance or other specific device memory handling (eg for
secure partitioning). Using bus_dma allows for these usecases.

The virtio buffers are marked as coherent; this should ensure that sync
calls are no-ops in the common cases.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70726
Build 67609: arc lint + arc unit

Event Timeline

sarah.walker2_arm.com created this revision.Fri, Jan 30, 11:14 AM
Herald added a subscriber: imp. · View Herald TranscriptFri, Jan 30, 11:14 AM
sarah.walker2_arm.com requested review of this revision.Fri, Jan 30, 11:14 AM
Harbormaster completed remote builds in B70228: Diff 170770.Fri, Jan 30, 11:14 AM
sarah.walker2_arm.com added a parent revision: D54959: virtio: Use bus_dma for ring and indirect buffer allocations.Fri, Jan 30, 11:14 AM
andrew added reviewers: bryanv, andrew.Mon, Feb 2, 5:43 PM
br mentioned this in D55220: virtio: get a correct tag for IOMMU operation.Tue, Feb 10, 2:05 PM
br added a subscriber: br.Mon, Feb 16, 10:48 AM
br added inline comments.
sys/dev/virtio/block/virtio_blk.c
1009

looks like the tag/map mismatch and below

sarah.walker2_arm.com updated this revision to Diff 171974.Mon, Feb 16, 2:35 PM

Fix DMAT used for vbr_ack

Harbormaster completed remote builds in B70701: Diff 171974.Mon, Feb 16, 2:35 PM
br added inline comments.Mon, Feb 16, 3:19 PM
sys/dev/virtio/block/virtio_blk.c
1012

one more mismatch

sarah.walker2_arm.com updated this revision to Diff 171978.Mon, Feb 16, 3:28 PM

Fix DMAT used for vbr_hdr.

Harbormaster completed remote builds in B70703: Diff 171978.Mon, Feb 16, 3:28 PM
br added inline comments.Tue, Feb 17, 8:58 AM
sys/dev/virtio/block/virtio_blk.c
956–957

panic() calls left from debugging have to be removed

sarah.walker2_arm.com updated this revision to Diff 172057.Tue, Feb 17, 9:21 AM

Remove panic() calls, fix error handling.

Harbormaster completed remote builds in B70726: Diff 172057.Tue, Feb 17, 9:21 AM
andrew added inline comments.Tue, Feb 17, 12:19 PM
sys/dev/virtio/block/virtio_blk.c
452

I expect we will need to put the new tags here too.

br added inline comments.Tue, Feb 17, 2:30 PM
sys/dev/virtio/block/virtio_blk.c
452

Another option is to remove this call ? With the patch adding bus DMA support, the addresses in the descriptors rings are now bus addresses rather than physical ones, which is what the IOMMU expects.
Unlike ARM64 and RISC-V, the powerpc busdma backend implements iommu operation within the main busdma backend, not as external one found in sys/dev/iommu

andrew added inline comments.Tue, Feb 17, 4:15 PM
sys/dev/virtio/block/virtio_blk.c
452

It was added in D37891, so presumably they need to be physical addresses on PowerPC.

Revision Contents
Changeset List

PathSize
sys/
dev/
virtio/
block/
219 lines

Diff 172057

View Options

sys/dev/virtio/block/virtio_blk.c

Loading...