Paths

Table of Contentst

Differential D55104

arm64: Panic if the ID register isn't known
ClosedPublic
Actions

Authored by andrew on Feb 4 2026, 5:27 PM.

Tags

None

Referenced Files

	F163139874: D55104.id171157.diff
	Mon, Jul 20, 11:12 AM

	F163063560: D55104.diff
	Sun, Jul 19, 6:20 PM

	Unknown Object (File)
	Sun, Jul 19, 2:14 AM

	Unknown Object (File)
	Sat, Jul 18, 6:38 PM

	Unknown Object (File)
	Sat, Jul 18, 5:22 AM

	Unknown Object (File)
	Sat, Jul 18, 2:54 AM

	Unknown Object (File)
	Sat, Jul 18, 2:53 AM

	Unknown Object (File)
	Wed, Jul 15, 9:59 AM

View All 59 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG7a70c9fcff1d: arm64: Panic if the ID register isn't known
rG3b0b6aa2cd05: arm64: Panic if the ID register isn't known

Summary

This will allow for callers to be simplified & not need to check the
return status.

Keep the return type for now so this can be MFCd without breaking the
KBI.

Sponsored by: Arm Ltd

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Feb 4 2026, 5:27 PM

Herald added a reviewer: manu. · View Herald TranscriptFeb 4 2026, 5:27 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

andrew requested review of this revision.Feb 4 2026, 5:27 PM

Harbormaster completed remote builds in B70401: Diff 171157.Feb 4 2026, 5:27 PM

andrew added a parent revision: D55103: arm64: Move creating the ID register views earlier.Feb 4 2026, 5:27 PM

andrew added a child revision: D55105: arm64: Assume get_kernel_reg returns true.

Is this actually KBI or just internal KBI between kernel and vmm, which would always be in sync?

The only user of get_kernel_reg_iss_masked that I know about is vmm, however get_kernel_reg_iss is used via the get_kernel_reg macro in many places, see D55105 for the full list.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 9 2026, 5:25 PM

Closed by commit rG3b0b6aa2cd05: arm64: Panic if the ID register isn't known (authored by andrew). · Explain Why

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG3b0b6aa2cd05: arm64: Panic if the ID register isn't known.

andrew added a commit: rG7a70c9fcff1d: arm64: Panic if the ID register isn't known.Apr 8 2026, 2:01 PM

Revision Contents
Changeset List

Path

Size

sys/

arm64/

arm64/

4 lines

Diff 171555

sys/arm64/arm64/identcpu.c

Loading...