Page MenuHomeFreeBSD
Differential D55104

arm64: Panic if the ID register isn't known
ClosedPublic
Actions

Authored by andrew on Feb 4 2026, 5:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 14, 9:30 AM
Unknown Object (File)
Sat, Feb 28, 11:59 AM
Unknown Object (File)
Feb 20 2026, 8:31 PM
Unknown Object (File)
Feb 18 2026, 8:05 PM
Unknown Object (File)
Feb 18 2026, 8:05 PM
Unknown Object (File)
Feb 17 2026, 6:52 PM
Unknown Object (File)
Feb 17 2026, 3:29 PM
Unknown Object (File)
Feb 17 2026, 12:22 AM
View All 16 Files
Subscribers
emaste
imp
jrtc27

Details

Reviewers
manu
Group Reviewers
arm64
Commits
rG3b0b6aa2cd05: arm64: Panic if the ID register isn't known
Summary

This will allow for callers to be simplified & not need to check the
return status.

Keep the return type for now so this can be MFCd without breaking the
KBI.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew created this revision.Feb 4 2026, 5:27 PM
Herald added a reviewer: manu. · View Herald TranscriptFeb 4 2026, 5:27 PM
Herald added subscribers: emaste, imp. · View Herald Transcript
andrew requested review of this revision.Feb 4 2026, 5:27 PM
Harbormaster completed remote builds in B70401: Diff 171157.Feb 4 2026, 5:27 PM
andrew added a parent revision: D55103: arm64: Move creating the ID register views earlier.Feb 4 2026, 5:27 PM
andrew added a child revision: D55105: arm64: Assume get_kernel_reg returns true.
jrtc27 added a subscriber: jrtc27.Feb 4 2026, 5:30 PM

Is this actually KBI or just internal KBI between kernel and vmm, which would always be in sync?

andrew added a comment.Feb 4 2026, 5:42 PM

The only user of get_kernel_reg_iss_masked that I know about is vmm, however get_kernel_reg_iss is used via the get_kernel_reg macro in many places, see D55105 for the full list.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 9 2026, 5:25 PM
Closed by commit rG3b0b6aa2cd05: arm64: Panic if the ID register isn't known (authored by andrew). · Explain Why
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG3b0b6aa2cd05: arm64: Panic if the ID register isn't known.

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
4 lines

Diff 171555

View Options

sys/arm64/arm64/identcpu.c

Loading...