Page MenuHomeFreeBSD
Differential D55108

libdiff: Simplify truncation detection
ClosedPublic
Actions

Authored by des on Feb 4 2026, 6:35 PM.
Tags
None
Referenced Files
F163351501: D55108.id171163.diff
Wed, Jul 22, 10:15 AM
Unknown Object (File)
Tue, Jul 21, 7:34 PM
Unknown Object (File)
Mon, Jul 20, 2:00 AM
Unknown Object (File)
Wed, Jul 15, 5:46 AM
Unknown Object (File)
Wed, Jul 15, 5:46 AM
Unknown Object (File)
Tue, Jul 7, 10:09 PM
Unknown Object (File)
Thu, Jul 2, 4:58 AM
Unknown Object (File)
Thu, Jun 25, 8:03 AM
View All 66 Files
Subscribers
imp

Details

Reviewers
thj
kevans
Group Reviewers
Klara
Commits
rGb97396baca2b: libdiff: Simplify truncation detection
rGa689bfa4e25a: libdiff: Simplify truncation detection
Summary
  • Adjust the comment to reflect the fact that SIGBUS can occur not only if the file is truncated, but also if an I/O error occurs while paging in any part of it.
  • Instead of setting a flag, just return EIO.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70420
Build 67303: arc lint + arc unit

Revision Contents
Changeset List

PathSize
contrib/
libdiff/
include/
1 line
lib/
12 lines
lib/
libdiff/
tests/
3 lines
usr.bin/
diff/
4 lines

Diff 171180

View Options

contrib/libdiff/include/diff_main.h

Loading...
View Options

contrib/libdiff/lib/diff_atomize_text.c

Loading...
View Options

lib/libdiff/tests/libdiff_test.c

Loading...
View Options

usr.bin/diff/diffreg_new.c

Loading...