Differential D54941

rpc: correct resultproc_t's type
ClosedPublic
Actions

Authored by brooks on Jan 29 2026, 12:19 PM.

Tags

None

Referenced Files

	F147509422: D54941.id171020.diff
	Wed, Mar 11, 12:59 PM

	F147493365: D54941.id170678.diff
	Wed, Mar 11, 10:14 AM

	F147488228: D54941.id170766.diff
	Wed, Mar 11, 9:26 AM

	F147478907: D54941.id.diff
	Wed, Mar 11, 7:55 AM

	Unknown Object (File)
	Wed, Mar 11, 7:06 AM

	Unknown Object (File)
	Wed, Mar 11, 6:23 AM

	Unknown Object (File)
	Wed, Mar 11, 3:41 AM

	Unknown Object (File)
	Mon, Mar 9, 1:57 PM

View All 26 Files

Subscribers

Details

Reviewers

rmacklem
glebius
emaste
asomers
ngie
vangyzen

Group Reviewers

Commits

rG18d47c1856f4: rpc: correct resultproc_t's type

Summary

It takes exactly three arguments of known type.

Tweak the types of various resultproc_t functions to match the type (mostly
added const to struct pointers) allowing us to drop casts.

Effort: CHERI upstreaming
Sponsored by: DARPA, AFRL

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 70207
Build 67090: arc lint + arc unit

Event Timeline

brooks created this revision.Jan 29 2026, 12:19 PM

Herald added a reviewer: ngie. · View Herald TranscriptJan 29 2026, 12:19 PM

Herald added a subscriber: imp. · View Herald Transcript

brooks requested review of this revision.Jan 29 2026, 12:19 PM

Herald added a reviewer: cheri. · View Herald TranscriptJan 29 2026, 12:19 PM

Harbormaster completed remote builds in B70207: Diff 170678.Jan 29 2026, 12:19 PM

brooks added a parent revision: D54940: clnt_broadcast(3): fix eachresult argument type.Jan 29 2026, 12:19 PM

@brooks : not sure if my tree is out of date, but I found a few more references of potential concern:

% rg -l '\(resultproc_t\)' worktree/main/ | sort | sed -e 's,worktree/main/,,g'
...
usr.bin/rup/rup.c
usr.bin/rusers/rusers.c
usr.sbin/bootparamd/callbootd/callbootd.c
usr.sbin/ypbind/ypbind.c

Do those need to be changed?

In D54941#1256407, @ngie wrote:

...

Apart from that--the change looks good to go! Not spotting any obvious landmines in our $work fork either that would be hit by this change.

In D54941#1256407, @ngie wrote:
@brooks : not sure if my tree is out of date, but I found a few more references of potential concern:
% rg -l '\(resultproc_t\)' worktree/main/ | sort | sed -e 's,worktree/main/,,g'
...
usr.bin/rup/rup.c
usr.bin/rusers/rusers.c
usr.sbin/bootparamd/callbootd/callbootd.c
usr.sbin/ypbind/ypbind.c
Do those need to be changed?

Those are removed in D54940.

rebase

Harbormaster completed remote builds in B70226: Diff 170766.Jan 30 2026, 9:18 AM

glebius accepted this revision.Jan 30 2026, 8:41 PM

This revision is now accepted and ready to land.Jan 30 2026, 8:41 PM

vangyzen accepted this revision.Jan 31 2026, 12:50 AM

Closed by commit rG18d47c1856f4: rpc: correct resultproc_t's type (authored by brooks). · Explain WhyFeb 2 2026, 9:21 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rG18d47c1856f4: rpc: correct resultproc_t's type.

Revision Contents
Changeset List

Path

Size

contrib/

netbsd-tests/

lib/

libc/

rpc/

5 lines

include/

rpc/

3 lines

lib/

libc/

rpc/

8 lines

usr.bin/

rpcinfo/

8 lines

Diff 170678

contrib/netbsd-tests/lib/libc/rpc/t_rpc.c

Loading...

include/rpc/clnt.h

Loading...

lib/libc/rpc/rpc_soc.c

Loading...

usr.bin/rpcinfo/rpcinfo.c

Loading...