heimdal: Add missing function prototypes
ClosedPublic
Actions

Authored by jhb on Jan 28 2026, 9:31 PM.

Details

Reviewers

rmacklem
glebius
cy
adrian

Commits

rG472fe29a536d: heimdal: Add missing function prototypes
rG2255b09a75b7: heimdal: Add missing function prototypes
rG8a8dc73ef87b: heimdal: Add missing function prototypes

Summary

This fixes the build with GCC 14 on stable/14 which raises fatal
-Wimplicit-function-declaration warnings.

Fixes: 5000d023a446 ("heimdal-kadmin: Add support for the -f dump option")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70196
Build 67079: arc lint + arc unit

Event Timeline

jhb created this revision.Jan 28 2026, 9:31 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 28 2026, 9:31 PM

jhb requested review of this revision.Jan 28 2026, 9:31 PM

Harbormaster completed remote builds in B70196: Diff 170655.Jan 28 2026, 9:31 PM

jhb added a child revision: D54932: heimdal: Pass the correct pointer to free in an error case.Jan 28 2026, 9:31 PM

jhb added a reviewer: adrian.Jan 30 2026, 2:41 PM

Looks fine to me. I'll admit I didn't bother to look
to see if/where they get called.

This revision is now accepted and ready to land.Jan 31 2026, 4:41 AM

cy accepted this revision.Jan 31 2026, 3:53 PM

Closed by commit rG8a8dc73ef87b: heimdal: Add missing function prototypes (authored by jhb). · Explain WhyJan 31 2026, 5:03 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG8a8dc73ef87b: heimdal: Add missing function prototypes.

ngie added a commit: rG2255b09a75b7: heimdal: Add missing function prototypes.Feb 3 2026, 7:09 PM

ngie added a commit: rG472fe29a536d: heimdal: Add missing function prototypes.

Revision Contents
Changeset List

Path

Size

crypto/

heimdal/

lib/

hdb/

hdb-private.h

12 lines

Diff 170655

View Options

crypto/heimdal/lib/hdb/hdb-private.h

heimdal: Add missing function prototypesClosedPublicActions