Page MenuHomeFreeBSD

heimdal: Pass the correct pointer to free in an error case
ClosedPublic

Authored by jhb on Jan 28 2026, 9:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 14, 4:49 PM
Unknown Object (File)
Sat, Mar 14, 9:49 AM
Unknown Object (File)
Sat, Mar 14, 3:04 AM
Unknown Object (File)
Sat, Mar 14, 3:01 AM
Unknown Object (File)
Thu, Mar 5, 9:04 PM
Unknown Object (File)
Thu, Feb 26, 5:13 PM
Unknown Object (File)
Sun, Feb 15, 2:10 PM
Unknown Object (File)
Sat, Feb 14, 7:35 PM
Subscribers

Details

Summary

This fixes a warning reported by GCC 14 on stable/14:

crypto/heimdal/lib/hdb/keys.c:241:13: warning: 'free' called on pointer 'ext' with nonzero offset 16 [-Wfree-nonheap-object]

241 |             free(hist_keys);
    |             ^~~~~~~~~~~~~~~

crypto/heimdal/lib/hdb/keys.c:234:15: note: returned from 'calloc'

234 |         ext = calloc(1, sizeof (*ext));
    |               ^~~~~~~~~~~~~~~~~~~~~~~~

Fixes: 5000d023a446 ("heimdal-kadmin: Add support for the -f dump option")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable