Page MenuHomeFreeBSD

heimdal: Pass the correct pointer to free in an error case
ClosedPublic

Authored by jhb on Jan 28 2026, 9:31 PM.
Tags
None
Referenced Files
F154690629: D54932.id170656.diff
Wed, Apr 29, 6:02 AM
F154689956: D54932.id170656.diff
Wed, Apr 29, 6:00 AM
F154561108: D54932.id170863.diff
Tue, Apr 28, 10:18 PM
F154557872: D54932.id170863.diff
Tue, Apr 28, 10:09 PM
Unknown Object (File)
Tue, Apr 28, 5:28 AM
Unknown Object (File)
Sat, Apr 18, 9:40 AM
Unknown Object (File)
Sat, Apr 11, 1:19 AM
Unknown Object (File)
Sat, Apr 11, 12:37 AM
Subscribers

Details

Summary

This fixes a warning reported by GCC 14 on stable/14:

crypto/heimdal/lib/hdb/keys.c:241:13: warning: 'free' called on pointer 'ext' with nonzero offset 16 [-Wfree-nonheap-object]

241 |             free(hist_keys);
    |             ^~~~~~~~~~~~~~~

crypto/heimdal/lib/hdb/keys.c:234:15: note: returned from 'calloc'

234 |         ext = calloc(1, sizeof (*ext));
    |               ^~~~~~~~~~~~~~~~~~~~~~~~

Fixes: 5000d023a446 ("heimdal-kadmin: Add support for the -f dump option")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable