Page MenuHomeFreeBSD

heimdal: Pass the correct pointer to free in an error case
ClosedPublic

Authored by jhb on Jan 28 2026, 9:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 8, 12:31 AM
Unknown Object (File)
Sat, Jun 6, 5:39 AM
Unknown Object (File)
Mon, Jun 1, 8:36 PM
Unknown Object (File)
Fri, May 15, 6:00 PM
Unknown Object (File)
May 15 2026, 12:08 PM
Unknown Object (File)
May 14 2026, 8:23 AM
Unknown Object (File)
May 12 2026, 11:21 AM
Unknown Object (File)
May 12 2026, 6:07 AM
Subscribers

Details

Summary

This fixes a warning reported by GCC 14 on stable/14:

crypto/heimdal/lib/hdb/keys.c:241:13: warning: 'free' called on pointer 'ext' with nonzero offset 16 [-Wfree-nonheap-object]

241 |             free(hist_keys);
    |             ^~~~~~~~~~~~~~~

crypto/heimdal/lib/hdb/keys.c:234:15: note: returned from 'calloc'

234 |         ext = calloc(1, sizeof (*ext));
    |               ^~~~~~~~~~~~~~~~~~~~~~~~

Fixes: 5000d023a446 ("heimdal-kadmin: Add support for the -f dump option")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable