Page MenuHomeFreeBSD

heimdal: Pass the correct pointer to free in an error case
ClosedPublic

Authored by jhb on Jan 28 2026, 9:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 2, 5:57 PM
Unknown Object (File)
Fri, Oct 2, 4:55 PM
Unknown Object (File)
Tue, Sep 29, 7:23 PM
Unknown Object (File)
Tue, Sep 29, 5:08 PM
Unknown Object (File)
Wed, Sep 16, 11:40 AM
Unknown Object (File)
Wed, Sep 9, 6:28 AM
Unknown Object (File)
Tue, Sep 8, 1:20 PM
Unknown Object (File)
Tue, Sep 8, 3:04 AM
Subscribers

Details

Summary

This fixes a warning reported by GCC 14 on stable/14:

crypto/heimdal/lib/hdb/keys.c:241:13: warning: 'free' called on pointer 'ext' with nonzero offset 16 [-Wfree-nonheap-object]

241 |             free(hist_keys);
    |             ^~~~~~~~~~~~~~~

crypto/heimdal/lib/hdb/keys.c:234:15: note: returned from 'calloc'

234 |         ext = calloc(1, sizeof (*ext));
    |               ^~~~~~~~~~~~~~~~~~~~~~~~

Fixes: 5000d023a446 ("heimdal-kadmin: Add support for the -f dump option")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable