Page MenuHomeFreeBSD

heimdal: Pass the correct pointer to free in an error case
ClosedPublic

Authored by jhb on Jan 28 2026, 9:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 26, 1:58 AM
Unknown Object (File)
Sat, Jul 25, 2:33 PM
Unknown Object (File)
Fri, Jul 24, 8:21 PM
Unknown Object (File)
Tue, Jul 21, 12:40 PM
Unknown Object (File)
Sat, Jul 18, 7:18 PM
Unknown Object (File)
Wed, Jul 15, 7:04 AM
Unknown Object (File)
Wed, Jul 15, 7:04 AM
Unknown Object (File)
Wed, Jul 8, 3:10 PM
Subscribers

Details

Summary

This fixes a warning reported by GCC 14 on stable/14:

crypto/heimdal/lib/hdb/keys.c:241:13: warning: 'free' called on pointer 'ext' with nonzero offset 16 [-Wfree-nonheap-object]

241 |             free(hist_keys);
    |             ^~~~~~~~~~~~~~~

crypto/heimdal/lib/hdb/keys.c:234:15: note: returned from 'calloc'

234 |         ext = calloc(1, sizeof (*ext));
    |               ^~~~~~~~~~~~~~~~~~~~~~~~

Fixes: 5000d023a446 ("heimdal-kadmin: Add support for the -f dump option")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable