pf: Rationalize the ip_divert_ptr test
ClosedPublic
Actions

Authored by markj on Fri, Jan 23, 8:55 PM.

Details

Reviewers

kp
igoro
glebius

Commits

rG4775399b4e87: pf: Rationalize the ip_divert_ptr test
rG39878d24a690: pf: Rationalize the ip_divert_ptr test

Summary

If a rule has a divert port set, then we can reasonably predict that
ipdivert.ko is loaded, and in particular that ip_divert_ptr is set.

Moreover, in this case, if ipdivert.ko is not loaded we should just drop
the packet instead of ignoring the divert rule.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70084
Build 66967: arc lint + arc unit

Event Timeline

markj created this revision.Fri, Jan 23, 8:55 PM

Herald added subscribers: vegeta_tuxpowered.net, melifaro, farrokhi, imp. · View Herald TranscriptFri, Jan 23, 8:56 PM

markj requested review of this revision.Fri, Jan 23, 8:56 PM

Harbormaster completed remote builds in B70084: Diff 170289.Fri, Jan 23, 8:56 PM

markj added a child revision: D54846: pf tests: Set require.kmods in divert-to tests.Fri, Jan 23, 8:56 PM

glebius accepted this revision.Fri, Jan 23, 9:11 PM

This revision is now accepted and ready to land.Fri, Jan 23, 9:11 PM

kp accepted this revision.Sat, Jan 24, 11:41 AM

igoro accepted this revision.Sat, Jan 24, 3:44 PM

Closed by commit rG39878d24a690: pf: Rationalize the ip_divert_ptr test (authored by markj). · Explain WhyMon, Jan 26, 5:25 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG39878d24a690: pf: Rationalize the ip_divert_ptr test.

markj added a commit: rG4775399b4e87: pf: Rationalize the ip_divert_ptr test.Mon, Feb 9, 6:05 PM

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf.c

15 lines

Diff 170289

View Options

pf: Rationalize the ip_divert_ptr testClosedPublicActions