Page MenuHomeFreeBSD
Differential D6061

Implement SHA-512 truncated (224 and 256 bits)
ClosedPublic
Actions

Authored by allanjude on Apr 22 2016, 1:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 8, 8:26 PM
Unknown Object (File)
Wed, Dec 4, 7:09 AM
Unknown Object (File)
Fri, Nov 29, 1:57 PM
Unknown Object (File)
Thu, Nov 28, 8:09 PM
Unknown Object (File)
Thu, Nov 28, 2:17 PM
Unknown Object (File)
Thu, Nov 28, 2:15 PM
Unknown Object (File)
Nov 24 2024, 5:58 PM
Unknown Object (File)
Nov 23 2024, 6:58 PM
View All Files
Subscribers
bcr
cem
imp

Details

Reviewers
cem
jmg
delphij
cperciva
Group Reviewers
manpages
Commits
rS300903: Implement SHA-512 truncated (224 and 256 bits)
Summary

This implements SHA-512/256, which generates a 256 bit hash, but using SHA-512 so is faster than SHA-256 on 64bit platforms.

The main goal of this implementation is to enable support for this faster hashing algorithm in ZFS

This is the follow on to r292782

Test Plan

Verified against: http://csrc.nist.gov/groups/ST/toolkit/documents/Examples/SHA512_256.pdf

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4000
Build 4043: arc lint + arc unit

Event Timeline

allanjude updated this revision to Diff 15494.Apr 22 2016, 1:43 PM
allanjude retitled this revision from to Implement SHA-512 truncated (224 and 256 bits).
allanjude updated this object.
allanjude edited the test plan for this revision. (Show Details)
allanjude added reviewers: cperciva, jmg, delphij.
Herald added a reviewer: manpages. · View Herald TranscriptApr 22 2016, 1:43 PM
Herald added a subscriber: imp. · View Herald Transcript
bcr added a subscriber: bcr.Apr 22 2016, 1:49 PM

Found a typo.

sbin/md5/md5.1
87

I this think should be "a version".

allanjude updated this revision to Diff 15780.Apr 30 2016, 9:40 PM
allanjude edited edge metadata.

Fix typo spotted by bcr@

Herald edited edge metadata. · View Herald TranscriptApr 30 2016, 9:40 PM
cem added a subscriber: cem.May 26 2016, 6:35 PM
cem added inline comments.
sys/crypto/sha2/sha512c.c
331

what's "so are skipped" mean?

352–356

It seems like these aren't really necessary. I'd suggest removing them and adding a comment where they were in the header to use the SHA512_Update() routine.

359

Use digest[static ...] here :).

369

don't need to cast here.

391–395

Same quibble here.

398

Use digest[static DIGEST_LEN] :)

408

same as above

sys/crypto/sha2/sha512t.h
107

[static DIGEST_LEN]

116

[static DIGEST_LEN]

cem added a reviewer: cem.May 26 2016, 6:35 PM
allanjude marked 7 inline comments as done.May 27 2016, 1:30 AM
allanjude added inline comments.
sys/crypto/sha2/sha512c.c
331

I didn't define the _transform function because it just uses the regular SHA512 one. I'll reword this

352–356

Userland applications that implement this algo expect this symbol to exist in libmd.

359

ok

369

right

allanjude updated this revision to Diff 16958.May 27 2016, 1:37 AM
allanjude marked 3 inline comments as done.
allanjude edited edge metadata.

Update with feedback from cem@

Herald edited edge metadata. · View Herald TranscriptMay 27 2016, 1:37 AM
cem added inline comments.May 27 2016, 4:03 PM
sys/crypto/sha2/sha512c.c
331

still needs rewording

352–356

It seems like userland-only routines and declarations should live in userland, like the _File/_Data routines. But whatever.

369

cast still present

408

This extra cast got missed :)

allanjude updated this revision to Diff 17023.May 28 2016, 4:40 AM
allanjude edited edge metadata.

Parts of the previous update did not get submitted

Herald edited edge metadata. · View Herald TranscriptMay 28 2016, 4:40 AM
allanjude marked 10 inline comments as done.May 28 2016, 4:41 AM
cem accepted this revision.May 28 2016, 2:00 PM
cem edited edge metadata.
This revision is now accepted and ready to land.May 28 2016, 2:00 PM
Closed by commit rS300903: Implement SHA-512 truncated (224 and 256 bits) (authored by allanjude). · Explain WhyMay 28 2016, 4:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
lib/
libcrypt/
2 lines
libmd/
37 lines
45 lines
4 lines
sbin/
md5/
6 lines
24 lines
16 lines
sys/
crypto/
sha2/
98 lines
125 lines

Diff 17023

View Options

lib/libcrypt/Makefile

Loading...
View Options

lib/libmd/Makefile

Loading...
View Options

lib/libmd/sha512.3

Loading...
View Options

lib/libmd/shadriver.c

Loading...
View Options

sbin/md5/Makefile

Loading...
View Options

sbin/md5/md5.1

Loading...
View Options

sbin/md5/md5.c

Loading...
View Options

sys/crypto/sha2/sha512c.c

Loading...
View Options

sys/crypto/sha2/sha512t.h

Loading...