Details

I'm not sure I'm convinced that dir is actually always set, but I haven't spent that much time reading the above logic. An assertion on that here might be good to try and do something useful instead of infinitely looping, but I don't insist

this uses saner code variant for change just done recently

When you do that, you want to use a Fixes: <shorthash> (title) line at the bottom of the commit message, that way the commits stay together for all the interesting things that can happen with branches or downstream.

In D54759#1251338, @kevans wrote:

I'm not sure I'm convinced that dir is actually always set, but I haven't spent that much time reading the above logic. An assertion on that here might be good to try and do something useful instead of infinitely looping, but I don't insist

i tried to read too, seems like it has error checks for not set conditions

but,

while (stream && fdir != DIR_NONE && !err && !feof(stdin));

then?

add assert

This revision now requires review to proceed.Jan 17 2026, 11:51 PM

Harbormaster completed remote builds in B69959: Diff 169984.Jan 17 2026, 11:51 PM

assert is before loop now

Harbormaster completed remote builds in B69989: Diff 170062.Jan 19 2026, 4:59 PM

put {} back info if blocks because that's actually good idea

Harbormaster completed remote builds in B70068: Diff 170259.Jan 23 2026, 3:28 AM

adrian accepted this revision.Thu, May 28, 4:20 PM

This revision is now accepted and ready to land.Thu, May 28, 4:20 PM

adrian added inline comments.Thu, May 28, 4:22 PM

usr.sbin/spi/spi.c
367–368	note - assert doesn't always get compiled in. It's only compiled in with -DDEBUG. I recommend handling it in a case statement with a default: switch (fdir) { case DIR_READ: <foo> break; case DIR_WRITE: <foo> break; case DIR_READWRITE: <foo> break; default: fprintf(stderr, "Invalid state (%d)\n", fdir); err = EINVAL; break; } That way you handle all of the valid ones and capture any other states.