Page MenuHomeFreeBSD

reviews-freebsd-org412_ketas.si.pri.ee (Sulev-Madis Silber)
ketas

Projects

User does not belong to any projects.

User Details

User Since
Nov 5 2025, 2:23 PM (14 w, 5 d)

Recent Activity

Fri, Jan 23

reviews-freebsd-org412_ketas.si.pri.ee updated the diff for D54759: spi: use better logic for earlier change.

put {} back info if blocks because that's actually good idea

Fri, Jan 23, 3:28 AM

Mon, Jan 19

reviews-freebsd-org412_ketas.si.pri.ee updated the diff for D54759: spi: use better logic for earlier change.

assert is before loop now

Mon, Jan 19, 4:59 PM

Sat, Jan 17

reviews-freebsd-org412_ketas.si.pri.ee updated the diff for D54759: spi: use better logic for earlier change.

add assert

Sat, Jan 17, 11:51 PM
reviews-freebsd-org412_ketas.si.pri.ee added a comment to D54759: spi: use better logic for earlier change.

I'm not sure I'm convinced that dir is actually always set, but I haven't spent that much time reading the above logic. An assertion on that here might be good to try and do something useful instead of infinitely looping, but I don't insist

Sat, Jan 17, 8:35 PM
reviews-freebsd-org412_ketas.si.pri.ee added reviewers for D54759: spi: use better logic for earlier change: ziaee, imp.
Sat, Jan 17, 5:01 PM
reviews-freebsd-org412_ketas.si.pri.ee added reviewers for D54759: spi: use better logic for earlier change: adrian, kevans.
Sat, Jan 17, 5:00 PM

Jan 17 2026

reviews-freebsd-org412_ketas.si.pri.ee requested review of D54759: spi: use better logic for earlier change.
Jan 17 2026, 4:59 PM
reviews-freebsd-org412_ketas.si.pri.ee added a comment to D54734: spi(8) - "-S" option for continuous stream from standard input to bus.

i was thinking of that already. that there must be way to run that while loop once with stream == 0. this is even better maybe as it shoots first and asks questions later. maybe it fits as there's no extra useless check. anyway i was always like how about an Actual C Coder (TM) *also* reviewing this

Jan 17 2026, 2:09 PM

Jan 16 2026

reviews-freebsd-org412_ketas.si.pri.ee added a comment to D54734: spi(8) - "-S" option for continuous stream from standard input to bus.

The manpage could do with a bit more work but we can work on that a bit after landing. Lemme get some more eyeballs on this.

Jan 16 2026, 1:17 AM

Jan 15 2026

reviews-freebsd-org412_ketas.si.pri.ee requested review of D54734: spi(8) - "-S" option for continuous stream from standard input to bus.
Jan 15 2026, 8:06 PM

Nov 5 2025

reviews-freebsd-org412_ketas.si.pri.ee requested review of D53597: rc: better method to load rc.conf's.
Nov 5 2025, 6:42 PM
reviews-freebsd-org412_ketas.si.pri.ee updated reviews-freebsd-org412_ketas.si.pri.ee.
Nov 5 2025, 5:33 PM