spi: use better logic for earlier change

[reviews-freebsd-org412_ketas.si.pri.ee]

Summary

this uses saner code variant for change just done recently

[kevans]

I'm not sure I'm convinced that dir is actually always set, but I haven't spent that much time reading the above logic. An assertion on that here might be good to try and do something useful instead of infinitely looping, but I don't insist

[ziaee]

this uses saner code variant for change just done recently

When you do that, you want to use a Fixes: <shorthash> (title) line at the bottom of the commit message, that way the commits stay together for all the interesting things that can happen with branches or downstream.

[reviews-freebsd-org412_ketas.si.pri.ee]

In D54759#1251338, @kevans wrote:

I'm not sure I'm convinced that dir is actually always set, but I haven't spent that much time reading the above logic. An assertion on that here might be good to try and do something useful instead of infinitely looping, but I don't insist

i tried to read too, seems like it has error checks for not set conditions

but,

while (stream && fdir != DIR_NONE && !err && !feof(stdin));

then?

[reviews-freebsd-org412_ketas.si.pri.ee]

add assert

[reviews-freebsd-org412_ketas.si.pri.ee]

assert is before loop now

[reviews-freebsd-org412_ketas.si.pri.ee]

put {} back info if blocks because that's actually good idea