powerpc: fix release image building for Apple partitions
ClosedPublic
Actions

Authored by adrian on Sun, Jan 11, 4:06 AM.

Details

Reviewers

jhibbits
imp

Commits

rG7afa03963c44: powerpc: fix release image building for Apple partitions

Summary

awk changed somewhere between 14 and 15 and it stopped accepting
a hexadecimal number as its input - it will always return 0.
This results in a very badly written apple boot block.

PR: kern/292341

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 69789
Build 66672: arc lint + arc unit

Event Timeline

adrian created this revision.Sun, Jan 11, 4:06 AM

Herald added subscribers: ivy, jrtc27, imp. · View Herald TranscriptSun, Jan 11, 4:06 AM

adrian requested review of this revision.Sun, Jan 11, 4:06 AM

Harbormaster completed remote builds in B69788: Diff 169457.Sun, Jan 11, 4:06 AM

adrian planned changes to this revision.Sun, Jan 11, 4:09 AM

adrian added reviewers: jhibbits, imp.

adrian added a project: PowerPC.

Herald added subscribers: alfredo, luporl, bdragon. · View Herald TranscriptSun, Jan 11, 4:09 AM

(no changes planned, please review!)

Impressive

release/powerpc/mkisoimages.sh
79–80	I think you could combine these lines, so `OFFSET=$(printf "%d" 0x${OFFSET} \| awk '{printf("%x\n",$1/512);}')`. But, also, the awk change looks to be a pretty significant bug, and should be fixed, too.

imp added inline comments.Sun, Jan 11, 6:37 AM

release/powerpc/mkisoimages.sh
78	Yes, upstream awk changed. I thought I'd found all the places. Just add `OFFSET= $(( 0x${OFFSET} / 512 ))` as the next line. you don't need awk for any of this.