Paths

Table of Contentst

Differential D54558

arm64: Enable MOPS in userspace
ClosedPublic
Actions

Authored by sarah.walker2_arm.com on Tue, Jan 6, 3:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jan 17, 1:05 AM

	Unknown Object (File)
	Fri, Jan 16, 9:01 PM

	Unknown Object (File)
	Fri, Jan 16, 2:41 PM

	Unknown Object (File)
	Fri, Jan 16, 7:27 AM

	Unknown Object (File)
	Fri, Jan 16, 6:23 AM

	Unknown Object (File)
	Fri, Jan 16, 4:38 AM

	Unknown Object (File)
	Fri, Jan 16, 3:32 AM

	Unknown Object (File)
	Thu, Jan 15, 10:02 PM

View All 30 Files

Subscribers

Details

Reviewers

andrew
manu
jrtc27

Group Reviewers

Commits

rG591c7a08bf8a: arm64: Enable MOPS in userspace

Summary

Detect presence of FEAT_MOPS, and enable instruction set and set HWCAP2 flag
if present.

Add handler for MOE exceptions.

Sponsored by: Arm Ltd

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 69758
Build 66641: arc lint + arc unit

Event Timeline

sarah.walker2_arm.com created this revision.Tue, Jan 6, 3:41 PM

Herald added a reviewer: andrew. · View Herald TranscriptTue, Jan 6, 3:41 PM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: emaste, imp. · View Herald Transcript

sarah.walker2_arm.com requested review of this revision.Tue, Jan 6, 3:41 PM

Harbormaster completed remote builds in B69661: Diff 169188.Tue, Jan 6, 3:41 PM

sarah.walker2_arm.com added a child revision: D54559: rtld-elf: Pass HWCAP flags to ifunc resolver functions.Tue, Jan 6, 3:41 PM

andrew added a reviewer: arm64.Tue, Jan 6, 4:05 PM

andrew added inline comments.

sys/arm64/arm64/machdep.c
240	Do we need an `isb` here and below? I assume it's probably safe for userspace only MOPS. In the kernel I expect we would need it as there may not be a context synchronising event before a MOPS instruction is used.
sys/arm64/include/armreg.h
603–606	In the Arm ARM M.a.a there is a single `FormatOption` field holding the old `OptionA` and `WrongOption` fields (bits 17:16).

Address review comments. Update SHA IFUNC usage.

Harbormaster completed remote builds in B69710: Diff 169310.Thu, Jan 8, 10:49 AM

Address review comments.

Harbormaster completed remote builds in B69711: Diff 169311.Thu, Jan 8, 10:51 AM

andrew accepted this revision.Thu, Jan 8, 3:46 PM

This revision is now accepted and ready to land.Thu, Jan 8, 3:46 PM

jrtc27 requested changes to this revision.Thu, Jan 8, 3:59 PM

jrtc27 added a subscriber: jrtc27.

jrtc27 added inline comments.

sys/arm64/arm64/identcpu.c
1098–1099	Indented with spaces not tabs

This revision now requires changes to proceed.Thu, Jan 8, 3:59 PM

jrtc27 added inline comments.Thu, Jan 8, 4:02 PM

sys/arm64/include/armreg.h
603	This define through OPTION_B2 uses spaces not tabs between the name and value
604	The 5 lines starting here exceed 80 chars, though there are already various violations of that in this file...
680	Uses spaces not tab before comment

Address review comments.

Harbormaster completed remote builds in B69758: Diff 169397.Fri, Jan 9, 4:03 PM

andrew accepted this revision.Fri, Jan 9, 5:35 PM

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Jan 14, 1:01 AM

Closed by commit rG591c7a08bf8a: arm64: Enable MOPS in userspace (authored by sarah.walker2_arm.com, committed by andrew). · Explain Why

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG591c7a08bf8a: arm64: Enable MOPS in userspace.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

arm64/

8 lines

35 lines

64 lines

include/

26 lines

Diff 169397

sys/arm64/arm64/identcpu.c

Loading...

sys/arm64/arm64/machdep.c

Loading...

sys/arm64/arm64/trap.c

Loading...

sys/arm64/include/armreg.h

Loading...