Page MenuHomeFreeBSD
Differential D54567

netstat: fix a segfault with --libxo
ClosedPublic
Actions

Authored by asomers on Tue, Jan 6, 10:22 PM.
Tags
None
Referenced Files
F141928485: D54567.diff
Mon, Jan 12, 10:27 PM
Unknown Object (File)
Sat, Jan 10, 5:45 PM
Unknown Object (File)
Sat, Jan 10, 6:07 AM
Unknown Object (File)
Sat, Jan 10, 6:03 AM
Unknown Object (File)
Fri, Jan 9, 9:57 PM
Unknown Object (File)
Fri, Jan 9, 9:32 PM
Unknown Object (File)
Fri, Jan 9, 2:40 PM
Unknown Object (File)
Fri, Jan 9, 1:31 PM
View All 14 Files
Subscribers
des
imp

Details

Reviewers
tuexen
js
des
Commits
rG3b6615ec0332: netstat: fix a segfault with --libxo
Summary

Fix a segfault when printing the "protocol" field. The field-format and
encoding-format were expecting different numbers of arguments.

PR: 292228
Fixes: c2b08c13c20 netstat: add support for UDP-Lite endpoints
MFC after: 1 week
Sponsored by: ConnectWise

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 69681
Build 66564: arc lint + arc unit

Event Timeline

asomers created this revision.Tue, Jan 6, 10:22 PM
Herald added a subscriber: imp. · View Herald TranscriptTue, Jan 6, 10:22 PM
asomers requested review of this revision.Tue, Jan 6, 10:22 PM
Harbormaster completed remote builds in B69673: Diff 169221.Tue, Jan 6, 10:23 PM
tuexen accepted this revision.Tue, Jan 6, 11:38 PM
This revision is now accepted and ready to land.Tue, Jan 6, 11:38 PM
des added a subscriber: des.Wed, Jan 7, 11:21 AM

can you also fix the padding in tcp-state?

des added inline comments.Wed, Jan 7, 11:23 AM
usr.bin/netstat/inet.c
396–401
js accepted this revision.Wed, Jan 7, 11:56 AM
asomers updated this revision to Diff 169236.Wed, Jan 7, 1:41 PM
  • Style, suggested by des@
  • Fix the encoded width of tcp-state, suggested by @des
This revision now requires review to proceed.Wed, Jan 7, 1:41 PM
Harbormaster completed remote builds in B69681: Diff 169236.Wed, Jan 7, 1:41 PM
des accepted this revision.Wed, Jan 7, 2:04 PM
This revision is now accepted and ready to land.Wed, Jan 7, 2:04 PM
tuexen accepted this revision.Wed, Jan 7, 2:08 PM
js accepted this revision.Wed, Jan 7, 2:09 PM
Closed by commit rG3b6615ec0332: netstat: fix a segfault with --libxo (authored by asomers). · Explain WhyWed, Jan 7, 2:35 PM
This revision was automatically updated to reflect the committed changes.
asomers added a commit: rG3b6615ec0332: netstat: fix a segfault with --libxo.

Revision Contents
Changeset List

PathSize
usr.bin/
netstat/
13 lines

Diff 169236

View Options

usr.bin/netstat/inet.c

Loading...