Page MenuHomeFreeBSD
Differential D6578

if.c: no need for trylock
ClosedPublic
Actions

Authored by bz on May 26 2016, 1:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 15, 6:19 AM
Unknown Object (File)
Sun, Nov 9, 9:39 AM
Unknown Object (File)
Wed, Nov 5, 4:11 PM
Unknown Object (File)
Mon, Oct 27, 7:38 AM
Unknown Object (File)
Mon, Oct 27, 7:38 AM
Unknown Object (File)
Mon, Oct 27, 7:38 AM
Unknown Object (File)
Mon, Oct 27, 2:00 AM
Unknown Object (File)
Oct 11 2025, 12:56 PM
View All Files
Subscribers
imp
network

Details

Reviewers
markj
gnn
rwatson
Commits
rS300901: In if_attachdomain1() there does not seem to be any reason
Summary

In if_attachdomain1() there does not seem to be any reason
to use TRYLOCK rather than just acquire the lock.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

bz updated this revision to Diff 16907.May 26 2016, 1:48 PM
bz retitled this revision from to if.c: no need for trylock.
bz updated this object.
bz edited the test plan for this revision. (Show Details)
bz added reviewers: gnn, markj, rwatson.
bz set the repository for this revision to rS FreeBSD src repository - subversion.
bz added a subscriber: network.
Herald added a subscriber: imp. · View Herald TranscriptMay 26 2016, 1:48 PM
markj accepted this revision.May 26 2016, 8:28 PM
markj edited edge metadata.

LGTM. I can't see any reason based on the history of the change that introduced this.

This revision is now accepted and ready to land.May 26 2016, 8:28 PM
Closed by commit rS300901: In if_attachdomain1() there does not seem to be any reason (authored by bz). · Explain WhyMay 28 2016, 8:32 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
net/
3 lines

Diff 16907

View Options

sys/net/if.c

Loading...