Page MenuHomeFreeBSD
Differential D53086

fusefs: kernel-based implementation of auto_unmount
AcceptedPublic
Actions

Authored by arrowd on Oct 14 2025, 4:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 21, 9:56 PM
Unknown Object (File)
Wed, Jan 21, 6:50 PM
Unknown Object (File)
Tue, Jan 20, 8:08 AM
Unknown Object (File)
Thu, Jan 15, 12:49 PM
Unknown Object (File)
Mon, Jan 5, 5:18 PM
Unknown Object (File)
Sun, Jan 4, 6:06 PM
Unknown Object (File)
Sun, Jan 4, 11:48 AM
Unknown Object (File)
Wed, Dec 31, 1:46 AM
View All 46 Files
Subscribers
asomers
imp
ziaee

Details

Reviewers
asomers
Summary

As it was suggested in D51549 here goes an attempt to implement the auto_unmount feature from within the kernel.

Corresponding libfuse changes are there: https://github.com/libfuse/libfuse/compare/master...arrowd:libfuse:kernel-bsd-auto-unmount

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 69066
Build 65949: arc lint + arc unit

Event Timeline

arrowd created this revision.Oct 14 2025, 4:27 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 14 2025, 4:27 PM
arrowd requested review of this revision.Oct 14 2025, 4:27 PM
Harbormaster completed remote builds in B67769: Diff 164154.Oct 14 2025, 4:27 PM
arrowd edited the summary of this revision. (Show Details)Oct 14 2025, 4:30 PM
arrowd updated this revision to Diff 165029.Oct 25 2025, 6:58 PM
  • Fix hang by marking fdata dead
Harbormaster completed remote builds in B68117: Diff 165029.Oct 25 2025, 6:58 PM
arrowd added a comment.Oct 25 2025, 6:59 PM

I have fixed the hang, but the filesystem still does not get unmounted.

arrowd updated this revision to Diff 167378.Dec 1 2025, 6:28 PM
  • Replace VOP_UNMOUNT with dounmount
  • Plunk vfs_ref before to avoid deadlock

This implementation seems to work now

Harbormaster completed remote builds in B68966: Diff 167378.Dec 1 2025, 6:28 PM
arrowd added inline comments.Dec 2 2025, 6:02 AM
sys/fs/fuse/fuse_vfsops.c
421

It seems to be too late to arm this flag there. I guess I'll have to set it from userspace.

arrowd updated this revision to Diff 167576.Dec 5 2025, 1:56 PM
  • Use cdev destructor to clean up the mount point instead of a .d_close method
Harbormaster completed remote builds in B69066: Diff 167576.Dec 5 2025, 1:56 PM
arrowd added a comment.Dec 5 2025, 1:59 PM

This seems to work now. The change turned out to be surprisingly small.

@asomers Could you take a look?

arrowd edited the summary of this revision. (Show Details)Dec 5 2025, 2:19 PM
arrowd added a comment.Dec 19 2025, 5:56 PM

Ping.

arrowd retitled this revision from fusefs: draft kernel-based implementation of auto_unmount to fusefs: kernel-based implementation of auto_unmount.Thu, Jan 8, 2:09 PM

Ping.

asomers requested changes to this revision.Tue, Jan 20, 12:20 AM

Wow! This looks much simpler than the original userspace-based implementation. I like it. I wrote some tests, too. I can commit those separately if you like, after you commit the main code. The only thing that's missing is a mention of the new option in mount_fusefs.8 . Could you please add that?

sys/fs/fuse/fuse_ipc.h
243

This is going to conflict with e8449c0e0fcb8a3eb5872cbee5c3dde4b05a5f50 . Easy to resolve.

This revision now requires changes to proceed.Tue, Jan 20, 12:20 AM
arrowd updated this revision to Diff 170191.Wed, Jan 21, 3:31 PM
  • Rebase
  • Update the man page
Herald added a subscriber: ziaee. · View Herald TranscriptWed, Jan 21, 3:31 PM
Harbormaster completed remote builds in B70041: Diff 170191.Wed, Jan 21, 3:31 PM
arrowd marked an inline comment as done.Wed, Jan 21, 3:31 PM

I can commit those separately if you like, after you commit the main code.

Thank you for following up with tests! I trust you to push them.

asomers accepted this revision.Wed, Jan 21, 4:45 PM

Approved, but don't forget to bump the man page's .Dd date.

This revision is now accepted and ready to land.Wed, Jan 21, 4:45 PM

Revision Contents
Changeset List

PathSize
sbin/
mount_fusefs/
2 lines
sys/
fs/
fuse/
6 lines
3 lines
1 line

Diff 167576

View Options

sbin/mount_fusefs/mount_fusefs.c

Loading...
View Options

sys/fs/fuse/fuse_device.c

Loading...
View Options

sys/fs/fuse/fuse_ipc.h

Loading...
View Options

sys/fs/fuse/fuse_vfsops.c

Loading...