ipdivert: Use CK_SLISTs for the divcb hash table
ClosedPublic
Actions

Authored by markj on Dec 1 2025, 2:31 PM.

Tags

None

Referenced Files

	F166942657: D54011.id.diff
	Mon, Aug 17, 11:07 PM

	F166940575: D54011.id167474.diff
	Mon, Aug 17, 10:35 PM

	Unknown Object (File)
	Sat, Aug 15, 10:40 PM

	Unknown Object (File)
	Wed, Aug 12, 1:30 PM

	Unknown Object (File)
	Sun, Aug 9, 3:22 AM

	Unknown Object (File)
	Sat, Aug 8, 5:07 PM

	Unknown Object (File)
	Sat, Aug 8, 4:30 PM

	Unknown Object (File)
	Sat, Aug 8, 11:13 AM

Subscribers

Details

Reviewers

Group Reviewers

network

Commits

rGe29fe1c251a1: divert: Use CK_SLISTs for the divcb hash table
rG74f7e916211a: divert: Use CK_SLISTs for the divcb hash table

Summary

The hash table is accessed in ip_divert_packet(), and there the accesses
are synchronized only by the net epoch, so plain SLIST is not safe.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 68956
Build 65839: arc lint + arc unit

Event Timeline

markj created this revision.Dec 1 2025, 2:31 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptDec 1 2025, 2:31 PM

markj requested review of this revision.Dec 1 2025, 2:31 PM

Harbormaster completed remote builds in B68956: Diff 167360.Dec 1 2025, 2:31 PM

ae accepted this revision.Dec 3 2025, 1:38 AM

This revision is now accepted and ready to land.Dec 3 2025, 1:38 AM

Closed by commit rG74f7e916211a: divert: Use CK_SLISTs for the divcb hash table (authored by markj). · Explain WhyDec 3 2025, 2:44 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG74f7e916211a: divert: Use CK_SLISTs for the divcb hash table.

markj added a commit: rGe29fe1c251a1: divert: Use CK_SLISTs for the divcb hash table.Dec 11 2025, 6:06 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

ip_divert.c

18 lines

Diff 167360

View Options

ipdivert: Use CK_SLISTs for the divcb hash tableClosedPublicActions