Page MenuHomeFreeBSD
Differential D53909

acpi: Fix setting sleep state sysctls to NONE
ClosedPublic
Actions

Authored by obiwac on Nov 25 2025, 9:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 20, 2:36 AM
Unknown Object (File)
Fri, Dec 19, 9:39 AM
Unknown Object (File)
Fri, Dec 19, 8:07 AM
Unknown Object (File)
Mon, Dec 15, 11:39 AM
Unknown Object (File)
Sun, Dec 14, 12:44 PM
Unknown Object (File)
Mon, Dec 8, 8:09 AM
Unknown Object (File)
Dec 1 2025, 4:41 PM
Unknown Object (File)
Nov 30 2025, 10:26 AM
View All 15 Files
Subscribers
emaste
imp

Details

Reviewers
glebius
thj
Commits
rGeeaa865edba6: acpi: Fix setting sleep state sysctls to NONE
Summary

This restores the functionality as it was pre-97d152698f48.

A stopgap was committed by glebius@ in 34dfccc64f47 ("acpi: in
acpi_stype_sysctl() use same logic as in acpi_sleep_state_sysctl()").

PR: 290651
Fixes: 97d152698f48 ("acpi: Use sleep types defined in sys/power.h")

Sponsored by: The FreeBSD Foundation

(I have fixed some typos in here too, which I'll commit separately.)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

obiwac created this revision.Nov 25 2025, 9:17 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 25 2025, 9:17 PM
obiwac requested review of this revision.Nov 25 2025, 9:17 PM
Harbormaster completed remote builds in B68843: Diff 167097.Nov 25 2025, 9:17 PM
obiwac added a reviewer: thj.Nov 25 2025, 9:19 PM
obiwac edited the summary of this revision. (Show Details)
emaste added a subscriber: emaste.Nov 25 2025, 9:24 PM
thj accepted this revision.Nov 26 2025, 10:06 AM
This revision is now accepted and ready to land.Nov 26 2025, 10:06 AM
emaste added inline comments.Nov 26 2025, 3:30 PM
sys/dev/acpica/acpi.c
4321–4322

this is just for clarity?

4430–4447

IMO using braces on both sides of else (if one side needs them) is a small clarity improvement

obiwac added inline comments.Nov 26 2025, 5:15 PM
sys/dev/acpica/acpi.c
4321–4322

yeah, it was a bit weird to check this after checking if the first character was an S

Closed by commit rGeeaa865edba6: acpi: Fix setting sleep state sysctls to NONE (authored by obiwac). · Explain WhyNov 28 2025, 2:45 PM
This revision was automatically updated to reflect the committed changes.
obiwac added a commit: rGeeaa865edba6: acpi: Fix setting sleep state sysctls to NONE.

Revision Contents
Changeset List

PathSize
sys/
dev/
acpica/
39 lines

Diff 167241

View Options

sys/dev/acpica/acpi.c

Loading...