Differential D53754

rc.subr: Try to make svjc option handling a bit easier to read
ClosedPublic
Actions

Authored by markj on Nov 14 2025, 2:30 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Aug 18, 8:37 PM

	Unknown Object (File)
	Mon, Aug 17, 11:40 PM

	Unknown Object (File)
	Mon, Aug 17, 10:32 PM

	Unknown Object (File)
	Sun, Aug 16, 4:50 AM

	Unknown Object (File)
	Sat, Aug 15, 10:07 PM

	Unknown Object (File)
	Sat, Aug 15, 4:46 AM

	Unknown Object (File)
	Sun, Aug 9, 8:54 PM

	Unknown Object (File)
	Sun, Aug 9, 5:28 AM

View All 75 Files

Subscribers

Details

Reviewers

netchild
ivy
0mp

Group Reviewers

Commits

rGcd0e5f95d070: rc.subr: Try to make svjc option handling a bit easier to read
rG7861d051de2e: rc.subr: Try to make svjc option handling a bit easier to read

Summary

Specifically, make this code fit in fewer columns:

deindent cases to conform to the usual style,
use a local variable to minimize duplication in each case.

No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Nov 14 2025, 2:30 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 14 2025, 2:30 PM

markj requested review of this revision.Nov 14 2025, 2:30 PM

Harbormaster completed remote builds in B68634: Diff 166445.Nov 14 2025, 2:30 PM

Visual inspection: looks functionally equivalent, all options match their intend.
Test run: OK with 31 service jails (at least net_basic works ok).

This revision is now accepted and ready to land.Nov 14 2025, 5:55 PM

0mp accepted this revision.Nov 15 2025, 7:08 AM

Closed by commit rG7861d051de2e: rc.subr: Try to make svjc option handling a bit easier to read (authored by markj). · Explain WhyNov 18 2025, 4:25 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG7861d051de2e: rc.subr: Try to make svjc option handling a bit easier to read.

markj added a commit: rGcd0e5f95d070: rc.subr: Try to make svjc option handling a bit easier to read.Dec 8 2025, 2:17 PM

Revision Contents
Changeset List

Path

Size

libexec/

rc/

88 lines

Diff 166683

libexec/rc/rc.subr

Loading...