Page MenuHomeFreeBSD

[ipfw] Unbreak lookup src/dst-ip
ClosedPublic

Authored by lytboris_gmail.com on Nov 15 2025, 6:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 15, 2:01 AM
Unknown Object (File)
Mon, Apr 13, 7:33 PM
Unknown Object (File)
Sun, Apr 12, 6:43 PM
Unknown Object (File)
Sat, Apr 11, 3:14 PM
Unknown Object (File)
Tue, Apr 7, 7:18 AM
Unknown Object (File)
Mon, Apr 6, 3:48 PM
Unknown Object (File)
Thu, Mar 26, 7:42 PM
Unknown Object (File)
Thu, Mar 26, 7:42 PM

Details

Summary

There's a fallthough bug in a switch statement for lookup opcode caused by an extra else statement: legitimate IPv4 and IPv6 packets fall through to LOOKUP_DSCP case while they must exit switch.

Test Plan

Create rules

ipfw table mytable create type addr
ipfw table mytable add 192.168.0.0/16 # put your source address here
ipfw add count ip from any to any lookup src-ip mytable

Observe packets matching the rule

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable