Page MenuHomeFreeBSD

[ipfw] Unbreak lookup src/dst-ip
ClosedPublic

Authored by lytboris_gmail.com on Nov 15 2025, 6:39 PM.
Tags
None
Referenced Files
F146069876: D53775.diff
Fri, Feb 27, 1:20 PM
F146069857: D53775.diff
Fri, Feb 27, 1:20 PM
Unknown Object (File)
Thu, Feb 19, 1:09 PM
Unknown Object (File)
Wed, Feb 18, 1:48 AM
Unknown Object (File)
Tue, Feb 17, 11:52 AM
Unknown Object (File)
Tue, Feb 17, 11:52 AM
Unknown Object (File)
Tue, Feb 17, 12:57 AM
Unknown Object (File)
Mon, Feb 16, 1:20 PM

Details

Summary

There's a fallthough bug in a switch statement for lookup opcode caused by an extra else statement: legitimate IPv4 and IPv6 packets fall through to LOOKUP_DSCP case while they must exit switch.

Test Plan

Create rules

ipfw table mytable create type addr
ipfw table mytable add 192.168.0.0/16 # put your source address here
ipfw add count ip from any to any lookup src-ip mytable

Observe packets matching the rule

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable