Page MenuHomeFreeBSD

[ipfw] Unbreak lookup src/dst-ip
ClosedPublic

Authored by lytboris_gmail.com on Sat, Nov 15, 6:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 18, 5:50 PM
Unknown Object (File)
Tue, Nov 18, 5:50 PM
Unknown Object (File)
Tue, Nov 18, 5:49 PM
Unknown Object (File)
Tue, Nov 18, 5:44 PM
Unknown Object (File)
Tue, Nov 18, 10:29 AM
Unknown Object (File)
Mon, Nov 17, 12:06 PM
Unknown Object (File)
Sun, Nov 16, 9:52 AM
Unknown Object (File)
Sun, Nov 16, 6:12 AM

Details

Summary

There's a fallthough bug in a switch statement for lookup opcode caused by an extra else statement: legitimate IPv4 and IPv6 packets fall through to LOOKUP_DSCP case while they must exit switch.

Test Plan

Create rules

ipfw table mytable create type addr
ipfw table mytable add 192.168.0.0/16 # put your source address here
ipfw add count ip from any to any lookup src-ip mytable

Observe packets matching the rule

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped