Page MenuHomeFreeBSD

exterror.9: explain buffers and bios usage of extended errors
ClosedPublic

Authored by kib on Nov 18 2025, 4:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jul 10, 5:06 PM
Unknown Object (File)
Sat, Jul 4, 10:47 AM
Unknown Object (File)
Sat, Jun 27, 12:48 PM
Unknown Object (File)
Sat, Jun 27, 7:01 AM
Unknown Object (File)
Fri, Jun 26, 8:40 AM
Unknown Object (File)
Thu, Jun 25, 8:20 PM
Unknown Object (File)
Wed, Jun 24, 9:38 AM
Unknown Object (File)
Tue, Jun 23, 6:54 PM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib requested review of this revision.Nov 18 2025, 4:25 AM
pauamma_chezdork.com added inline comments.
share/man/man9/exterror.9
117
139–140

I don't understand what you mean by "internalize" here. Can you explain?

171

Pluralize consistently. (See line 209.)

194
209
kib marked 5 inline comments as done.Nov 18 2025, 4:45 AM
kib added inline comments.
share/man/man9/exterror.9
139–140

curthread has the extended error info internally. The function moves (well, copies) external exterror into that internal state.

kib marked an inline comment as done.

pauamma' fixes

s/to internalize/copying/ fixable on commit.

share/man/man9/exterror.9
139
This revision is now accepted and ready to land.Nov 18 2025, 4:51 AM
share/man/man9/exterror.9
139

Copying has the meaning of, well, copying of the plain set of bytes from one place into another. I do not want to allow this, which is why there is a helper function that does that. Even if internally it is indeed memcpy right now, that might change, this is why the KPI exterr_set_from() was added.

share/man/man9/exterror.9
139–140

Hmm. Point. On second thought, perhaps remove that whole sentence? I'm not sure what it adds to the previous one.

kib marked 2 inline comments as done.

Remove the sentence.

This revision now requires review to proceed.Nov 18 2025, 5:24 AM
This revision is now accepted and ready to land.Nov 18 2025, 5:33 AM