net/wifi-firmware-kmod: generalize iwlwifi specific tunable writing
Needs ReviewPublic
Actions

Authored by bz on Mon, Nov 17, 2:53 PM.

Details

Reviewers

jrm

Group Reviewers

Ports Committers

Summary

Currently iwlwifi(4) is the only LinuxKPI based wireless driver able
to enable 11n/11ac. bz has added tunables to rtw88 and rtw89 in order
to allow them to gradually enable more modern standards as well.

Generalize the ports framework to not be iwlwifi-specifc anymore
in order to prepare for Realtek and others to gain 11n and 11ac
support.

At some point in time, along with a kernel change, we will then flip
the defaults and make this a "disable" rather than an enable option.

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 68702
Build 65585: arc lint + arc unit

Event Timeline

bz requested review of this revision.Mon, Nov 17, 2:53 PM

bz created this revision.

Harbormaster completed remote builds in B68688: Diff 166572.Mon, Nov 17, 2:53 PM

bz added a parent revision: D53788: net/wifi-firmware-kmod: allow ONLY_FOR_ARCHS to be set by child ports.Mon, Nov 17, 8:23 PM

bz added a child revision: D53681: net/wifi-firmware-iwlwifi-kmod: update firmware to 20251021.

bz added a child revision: D53680: net/wifi-firmware-kmod: add STRIP_FWSUBDIR logic.

bz removed a child revision: D53681: net/wifi-firmware-iwlwifi-kmod: update firmware to 20251021.

bz removed a child revision: D53680: net/wifi-firmware-kmod: add STRIP_FWSUBDIR logic.Mon, Nov 17, 10:11 PM

bz edited parent revisions, added: D53680: net/wifi-firmware-kmod: add STRIP_FWSUBDIR logic; removed: D53788: net/wifi-firmware-kmod: allow ONLY_FOR_ARCHS to be set by child ports.

bz added a child revision: D53681: net/wifi-firmware-iwlwifi-kmod: update firmware to 20251021.

rebase

Harbormaster completed remote builds in B68702: Diff 166603.Mon, Nov 17, 10:22 PM

jrm added inline comments.Tue, Nov 18, 6:48 PM

net/wifi-firmware-kmod/Makefile.inc
128–130	Before you had `_11n_disable` and `_disable_11ac=0`. Now you have `_11n_disable`, `_disable_11n`, and `_disable_11ac`. Based on the comment, I believe this is intentional, but checking to be certain.

bz marked an inline comment as done.Tue, Nov 18, 8:18 PM

bz added inline comments.

net/wifi-firmware-kmod/Makefile.inc
128–130	Yes it is intentional; iwlwifi has the "non-standard" name for 11n; realtek I kept it the normal disable_11xx way but I don't want it to be port specific and as mentioned setting an unknown line does not us. Also see: https://man.freebsd.org/cgi/man.cgi?query=iwlwifi&apropos=0&sektion=0&manpath=FreeBSD+14.3-RELEASE+and+Ports&arch=default&format=html#LOADER_TUNABLES

bz marked an inline comment as done.Tue, Nov 18, 9:58 PM

bz added inline comments.

net/wifi-firmware-kmod/Makefile.inc
128–130	DOH! What did I do... I'll need to pull the drivers straight. Doesn't make sense to do it the other way round. Sigh. Doesn't matter as for any supported (shipping) version they are hard coded to what is supported there. But in the future (16.0, 15.1, 14.4) that will matter. compat.linuxkpi.rtw88_support_vht: 1 compat.linuxkpi.rtw88_support_ht: 1 So yes, the port is correct, the driver names are just silly but contrary to iwlwifi in rtw8x they are a (temporary) local addition of @bz. I hope we can just remove them all together after a period of testing again from rtw8x. Let's stay tuned.