Paths

Table of Contentst

Differential D53639

bsdinstall: Fix newfs bsddialog menu
ClosedPublic
Actions

Authored by emaste on Nov 7 2025, 10:58 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jul 21, 7:07 AM

	Unknown Object (File)
	Mon, Jul 20, 4:00 PM

	Unknown Object (File)
	Sun, Jul 19, 9:50 PM

	Unknown Object (File)
	Sun, Jul 19, 1:43 AM

	Unknown Object (File)
	Sat, Jul 18, 2:31 AM

	Unknown Object (File)
	Wed, Jul 15, 6:54 AM

	Unknown Object (File)
	Wed, Jul 15, 6:54 AM

	Unknown Object (File)
	Tue, Jul 14, 2:50 PM

View All 82 Files

Subscribers

Details

Reviewers

asiciliano
cperciva
imp

Commits

rG3ced4a2b482f: bsdinstall: Fix newfs bsddialog menu
rGe55b2f03215e: bsdinstall: Fix newfs bsddialog menu
rG980aa8d4cfdf: bsdinstall: Fix newfs bsddialog menu
rG4e3694242071: bsdinstall: Fix newfs bsddialog menu

Summary

The first 3 members of struct bsddialog_menuitem are:

                   const char *prefix;
                   bool on;
                   unsigned int depth;

The newfs dialog options in bsdinstall's partition tool had on and depth
swapped, so the defaults did not work.

PR: 290857
Fixes: 50e244964e9b ("bsdinstall/partedit: Replace libdialog with libbsddialog")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste created this revision.Nov 7 2025, 10:58 PM

Herald added a subscriber: jrtc27. · View Herald TranscriptNov 7 2025, 10:58 PM

emaste requested review of this revision.Nov 7 2025, 10:58 PM

emaste added inline comments.

usr.sbin/bsdinstall/partedit/gpart_ops.c
213	Separately this should probably just be `-F 32` without `-c 1`. I will look at that and post a patch after testing.

Thank you for finding this issue and the fix.

This revision is now accepted and ready to land.Nov 7 2025, 11:09 PM

Closed by commit rG4e3694242071: bsdinstall: Fix newfs bsddialog menu (authored by emaste). · Explain WhyNov 8 2025, 3:06 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG4e3694242071: bsdinstall: Fix newfs bsddialog menu.

emaste added a commit: rG980aa8d4cfdf: bsdinstall: Fix newfs bsddialog menu.Nov 10 2025, 3:07 AM

cperciva added a commit: rGe55b2f03215e: bsdinstall: Fix newfs bsddialog menu.Nov 10 2025, 7:01 PM

emaste added a commit: rG3ced4a2b482f: bsdinstall: Fix newfs bsddialog menu.Nov 12 2025, 3:48 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bsdinstall/

partedit/

14 lines

Diff 166070

usr.sbin/bsdinstall/partedit/gpart_ops.c

Loading...