Paths

Table of Contentst

Differential D53639

bsdinstall: Fix newfs bsddialog menu
ClosedPublic
Actions

Authored by emaste on Fri, Nov 7, 10:58 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 20, 2:00 AM

	Unknown Object (File)
	Thu, Nov 20, 1:55 AM

	Unknown Object (File)
	Thu, Nov 20, 1:55 AM

	Unknown Object (File)
	Thu, Nov 20, 1:50 AM

	Unknown Object (File)
	Mon, Nov 17, 4:48 PM

	Unknown Object (File)
	Sun, Nov 16, 7:13 AM

	Unknown Object (File)
	Sat, Nov 15, 11:28 AM

	Unknown Object (File)
	Sat, Nov 15, 11:28 AM

View All 24 Files

Subscribers

Details

Reviewers

asiciliano
cperciva
imp

Commits

rG3ced4a2b482f: bsdinstall: Fix newfs bsddialog menu
rGe55b2f03215e: bsdinstall: Fix newfs bsddialog menu
rG980aa8d4cfdf: bsdinstall: Fix newfs bsddialog menu
rG4e3694242071: bsdinstall: Fix newfs bsddialog menu

Summary

The first 3 members of struct bsddialog_menuitem are:

                   const char *prefix;
                   bool on;
                   unsigned int depth;

The newfs dialog options in bsdinstall's partition tool had on and depth
swapped, so the defaults did not work.

PR: 290857
Fixes: 50e244964e9b ("bsdinstall/partedit: Replace libdialog with libbsddialog")

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste created this revision.Fri, Nov 7, 10:58 PM

Herald added a subscriber: jrtc27. · View Herald TranscriptFri, Nov 7, 10:58 PM

emaste requested review of this revision.Fri, Nov 7, 10:58 PM

emaste added inline comments.

usr.sbin/bsdinstall/partedit/gpart_ops.c
212	Separately this should probably just be `-F 32` without `-c 1`. I will look at that and post a patch after testing.

Thank you for finding this issue and the fix.

This revision is now accepted and ready to land.Fri, Nov 7, 11:09 PM

Closed by commit rG4e3694242071: bsdinstall: Fix newfs bsddialog menu (authored by emaste). · Explain WhySat, Nov 8, 3:06 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG4e3694242071: bsdinstall: Fix newfs bsddialog menu.

emaste added a commit: rG980aa8d4cfdf: bsdinstall: Fix newfs bsddialog menu.Mon, Nov 10, 3:07 AM

cperciva added a commit: rGe55b2f03215e: bsdinstall: Fix newfs bsddialog menu.Mon, Nov 10, 7:01 PM

emaste added a commit: rG3ced4a2b482f: bsdinstall: Fix newfs bsddialog menu.Wed, Nov 12, 3:48 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bsdinstall/

partedit/

14 lines

Diff 166052

usr.sbin/bsdinstall/partedit/gpart_ops.c

Loading...