Page MenuHomeFreeBSD
Differential D53628

release: Comply with Azure Marketplace requirements for aarch64
ClosedPublic
Actions

Authored by lwhsu on Thu, Nov 6, 11:00 PM.
Tags
None
Referenced Files
F135661626: D53628.id.diff
Tue, Nov 11, 5:01 PM
F135661623: D53628.id166016.diff
Tue, Nov 11, 5:01 PM
F135661622: D53628.id165988.diff
Tue, Nov 11, 5:01 PM
F135642651: D53628.diff
Tue, Nov 11, 1:18 PM
Unknown Object (File)
Sun, Nov 9, 10:34 PM
Unknown Object (File)
Sun, Nov 9, 9:40 PM
Unknown Object (File)
Sun, Nov 9, 7:25 PM
Unknown Object (File)
Fri, Nov 7, 7:41 PM
View All 17 Files
Subscribers
ivy
jrtc27

Details

Reviewers
cperciva
brd
imp
Commits
rGfc5a01f8e9ea: release: Comply with Azure Marketplace requirements for aarch64
rG58f208591b59: release: Comply with Azure Marketplace requirements for aarch64
rG72617603a28f: release: Comply with Azure Marketplace requirements for aarch64
rG36095c942031: release: Comply with Azure Marketplace requirements for aarch64
Summary

This is based on D52734, ensure the BOOTPARTSOFFSET parameter only appended to
the first boot partition.

amd64:

=>      34  62984125  md0  GPT  (30G)
        34      2014       - free -  (1.0M)
      2048       122    1  freebsd-boot  (61K)
      2170     66584    2  efi  (33M)
     68754  62914560    3  freebsd-ufs  (30G)
  62983314       845       - free -  (423K)

aarch64:

=>      34  62984125  md0  GPT  (30G)
        34      2014       - free -  (1.0M)
      2048     66584    1  efi  (33M)
     68632  62914560    2  freebsd-ufs  (30G)
  62983192       967       - free -  (484K)

Purposed commit message:

release: Comply with Azure Marketplace requirements for aarch64

Azure requires the first 1 MB (2,048 sectors) of the OS disk to remain
empty for VM images:

  https://learn.microsoft.com/partner-center/marketplace-offers/azure-vm-certification-faq#vm-images-must-have-1-mb-of-free-space

Also append the BOOTPARTSOFFSET suffix for aarch64 images, which only
has an ESP partition for booting.

Co-authored-by:	Brad Davis <brd@FreeBSD.org>
Sponsored by:	The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 68469
Build 65352: arc lint + arc unit

Event Timeline

lwhsu created this revision.Thu, Nov 6, 11:00 PM
Herald added subscribers: ivy, jrtc27. · View Herald TranscriptThu, Nov 6, 11:00 PM
lwhsu requested review of this revision.Thu, Nov 6, 11:00 PM
Harbormaster completed remote builds in B68469: Diff 165988.Thu, Nov 6, 11:00 PM
cperciva added a comment.Thu, Nov 6, 11:33 PM

Where is BOOTPARTSOFFSET defined? Is there a missing patch to release/tools/azure.conf ?

lwhsu added a comment.Thu, Nov 6, 11:37 PM
In D53628#1224327, @cperciva wrote:

Where is BOOTPARTSOFFSET defined? Is there a missing patch to release/tools/azure.conf ?

In release/tools/azure.conf it's VM_BOOTPARTSOFFSET

In this file's vm_create_disk() it is converted to BOOTPARTSOFFSET and used in

	case "${TARGET}:${TARGET_ARCH}" in
		amd64:amd64 | i386:i386)

And this patch doing the same when dealing with ESP.

cperciva added a comment.Fri, Nov 7, 4:30 AM

Ah never mind, I accidentally grepped for "BOOTPARTOFFSET" instead of "BOOTPARTSOFFSET".

cperciva accepted this revision.Fri, Nov 7, 4:37 AM
This revision is now accepted and ready to land.Fri, Nov 7, 4:37 AM
Closed by commit rG36095c942031: release: Comply with Azure Marketplace requirements for aarch64 (authored by lwhsu). · Explain WhyFri, Nov 7, 5:12 AM
This revision was automatically updated to reflect the committed changes.
lwhsu added a commit: rG36095c942031: release: Comply with Azure Marketplace requirements for aarch64.
lwhsu added a commit: rG72617603a28f: release: Comply with Azure Marketplace requirements for aarch64.
cperciva added a commit: rG58f208591b59: release: Comply with Azure Marketplace requirements for aarch64.Fri, Nov 7, 5:22 AM
lwhsu added a commit: rGfc5a01f8e9ea: release: Comply with Azure Marketplace requirements for aarch64.Sat, Nov 8, 5:25 PM

Revision Contents
Changeset List

PathSize
release/
tools/
6 lines

Diff 165988

View Options

release/tools/vmimage.subr

Loading...