Page MenuHomeFreeBSD
Differential D53086

fusefs: draft kernel-based implementation of auto_unmount
Needs ReviewPublic
Actions

Authored by arrowd on Oct 14 2025, 4:27 PM.
Tags
None
Referenced Files
F140007444: D53086.id167378.diff
Thu, Dec 18, 11:02 PM
F140007438: D53086.id167576.diff
Thu, Dec 18, 11:02 PM
F140007419: D53086.id164154.diff
Thu, Dec 18, 11:02 PM
Unknown Object (File)
Tue, Dec 16, 5:41 PM
Unknown Object (File)
Thu, Dec 11, 4:07 AM
Unknown Object (File)
Fri, Nov 28, 1:44 AM
Unknown Object (File)
Wed, Nov 26, 10:28 PM
Unknown Object (File)
Nov 18 2025, 9:31 PM
View All 32 Files
Subscribers
asomers
imp

Details

Reviewers
asomers
Summary

As it was suggested in D51549 here goes an attempt to implement the auto_unmount feature from within the kernel.

Corresponding libfuse changes are there: https://github.com/libfuse/libfuse/compare/master...arrowd:libfuse:kernel-bsd-auto-unmount

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 67769
Build 64652: arc lint + arc unit

Event Timeline

arrowd created this revision.Oct 14 2025, 4:27 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 14 2025, 4:27 PM
arrowd requested review of this revision.Oct 14 2025, 4:27 PM
Harbormaster completed remote builds in B67769: Diff 164154.Oct 14 2025, 4:27 PM
arrowd edited the summary of this revision. (Show Details)Oct 14 2025, 4:30 PM
arrowd updated this revision to Diff 165029.Oct 25 2025, 6:58 PM
  • Fix hang by marking fdata dead
Harbormaster completed remote builds in B68117: Diff 165029.Oct 25 2025, 6:58 PM
arrowd added a comment.Oct 25 2025, 6:59 PM

I have fixed the hang, but the filesystem still does not get unmounted.

arrowd updated this revision to Diff 167378.Mon, Dec 1, 6:28 PM
  • Replace VOP_UNMOUNT with dounmount
  • Plunk vfs_ref before to avoid deadlock

This implementation seems to work now

Harbormaster completed remote builds in B68966: Diff 167378.Mon, Dec 1, 6:28 PM
arrowd added inline comments.Tue, Dec 2, 6:02 AM
sys/fs/fuse/fuse_vfsops.c
421

It seems to be too late to arm this flag there. I guess I'll have to set it from userspace.

arrowd updated this revision to Diff 167576.Fri, Dec 5, 1:56 PM
  • Use cdev destructor to clean up the mount point instead of a .d_close method
Harbormaster completed remote builds in B69066: Diff 167576.Fri, Dec 5, 1:56 PM
arrowd added a comment.Fri, Dec 5, 1:59 PM

This seems to work now. The change turned out to be surprisingly small.

@asomers Could you take a look?

arrowd edited the summary of this revision. (Show Details)Fri, Dec 5, 2:19 PM

Revision Contents
Changeset List

PathSize
sbin/
mount_fusefs/
2 lines
sys/
fs/
fuse/
28 lines
3 lines
4 lines

Diff 164154

View Options

sbin/mount_fusefs/mount_fusefs.c

Loading...
View Options

sys/fs/fuse/fuse_device.c

Loading...
View Options

sys/fs/fuse/fuse_ipc.h

Loading...
View Options

sys/fs/fuse/fuse_vfsops.c

Loading...