Makefile: Don't allow install{world,kernel} with pkgbase
ClosedPublic
Actions

Authored by ivy on Oct 3 2025, 2:00 AM.

Details

Reviewers

emaste

Group Reviewers

pkgbase

Commits

rG1998d706dfa9: Makefile: Don't allow install{world,kernel} with pkgbase
rGef82bdc864c5: Makefile: Don't allow install{world,kernel} with pkgbase
rG74a6bb524e5b: Makefile: Don't allow install{world,kernel} with pkgbase

Summary

Using these targets on a pkgbase system will cause the installed system
to become out of sync with the package database, which is almost certain
to cause issues the next time pkg(8) is used.

To prevent users doing this accidentally, disallow install* if we detect
that FreeBSD-runtime is installed in the target. The check can be
overridden with DESTDIR=/ for users who are sure they want to do this.

MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 67508
Build 64391: arc lint + arc unit

Event Timeline

ivy created this revision.Oct 3 2025, 2:00 AM

Herald added subscribers: emaste, imp. · View Herald TranscriptOct 3 2025, 2:00 AM

ivy requested review of this revision.Oct 3 2025, 2:00 AM

Harbormaster completed remote builds in B67508: Diff 163407.Oct 3 2025, 2:00 AM

I see the rationale for this as an anti-foot-shooting device, but I'm not sure if the FreeBSD user community is ready for this yet.

I'm inclined to either make this switch in 16 or email freebsd-current to solicit feedback first.

Looks like a reasonable safeguard.

not sure if the FreeBSD user community is ready for this yet

I could see this tripping up folks, but just as easily I can imagine someone using pkgbase, then installworld over top and complaining about a mixed-up installation.

portmaster_BSDforge.com added a subscriber: portmaster_BSDforge.com.Oct 7 2025, 11:06 PM

While I was initially an objector to this and am not a big fan of BASIFY. This seems like
a reasonable compromise that is easy enough to tool around. So as to keep current work
flows working w/o too much disruption. Thank you for taking the time to make this work
for everyone. :-)

i posted about this on stable@ and current@ a week ago and no has objected, so i'd really like to land this if possible.

In D52879#1209354, @emaste wrote:

I could see this tripping up folks, but just as easily I can imagine someone using pkgbase, then installworld over top and complaining about a mixed-up installation.

right. the difference is in the first case, the user just needs to learn the right way to do this dangerous action, in the second case the user ends up with a broken system with no warning. i think the first case is much preferable, because while this might mildly annoy users, the second case will be much more annoying :-)

and let's be clear, someone is going to do this by accident, and then complain that pkgbase broke their system... and they won't be entirely wrong about that if we let them do this.

arrowd added a subscriber: arrowd.Thu, Oct 16, 7:21 AM

arrowd added inline comments.

Makefile.inc1
1388	Can we add some `I_KNOW_WHAT_IM_DOING` override here, to make it still possible to run `make install{world,kernel}` on a pkgbase'd system?

arrowd added inline comments.Thu, Oct 16, 7:40 AM

Makefile.inc1
1388	I should've probably try reading the error message first. Sorry for the noise.

emaste accepted this revision as: emaste.Fri, Oct 17, 1:32 PM

emaste added inline comments.

Makefile.inc1
608	A little unfortunate that this is decoupled from the other pkg variables. Maybe move the rest of them up so they're still grouped with the `.if make(package)` in the middle of them?
1390	Maybe `${.TARGET} should not be used`?