Differential D52578

arm64: Read the CPU feature tunables once
ClosedPublic
Actions

Authored by andrew on Tue, Sep 16, 4:51 PM.

Tags

None

Referenced Files

	F130560655: D52578.diff
	Tue, Sep 30, 8:08 AM

	Unknown Object (File)
	Wed, Sep 24, 10:56 PM

	Unknown Object (File)
	Wed, Sep 24, 10:49 PM

	Unknown Object (File)
	Wed, Sep 24, 4:17 PM

	Unknown Object (File)
	Tue, Sep 23, 7:21 PM

	Unknown Object (File)
	Wed, Sep 17, 8:18 AM

	Unknown Object (File)
	Wed, Sep 17, 1:35 AM

	Unknown Object (File)
	Tue, Sep 16, 11:10 PM

View All 11 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG3c25261ea29c: arm64: Read the CPU feature tunables once
rG5e0e2565288f: arm64: Read the CPU feature tunables once

Summary

Rather than reading the CPU tunables each time we enable a feature
just read them once on boot. Reading them early on non-boot CPUs
causes issues where they try to allocate memory before the core is set
up to do so. As they don't change it is safe to cache the state of
them.

Sponsored by: Arm Ltd

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Tue, Sep 16, 4:51 PM

Herald added a reviewer: manu. · View Herald TranscriptTue, Sep 16, 4:51 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

andrew requested review of this revision.Tue, Sep 16, 4:51 PM

Harbormaster completed remote builds in B67085: Diff 162175.Tue, Sep 16, 4:51 PM

andrew added a parent revision: D52577: arm64: Add cpu_feat_disabled for disabled features.Tue, Sep 16, 4:51 PM

andrew added a child revision: D52579: arm64: Fix enabling CPU features.

andrew added a reviewer: arm64.Tue, Sep 16, 4:52 PM

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Sep 19, 10:36 AM

Closed by commit rG5e0e2565288f: arm64: Read the CPU feature tunables once (authored by andrew). · Explain Why

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG5e0e2565288f: arm64: Read the CPU feature tunables once.

andrew added a commit: rG3c25261ea29c: arm64: Read the CPU feature tunables once.Mon, Sep 22, 3:24 PM

Revision Contents
Changeset List

Path

Size

sys/

arm64/

arm64/

35 lines

include/

3 lines

Diff 162392

sys/arm64/arm64/cpu_feat.c

Loading...

sys/arm64/include/cpu_feat.h

Loading...