Page MenuHomeFreeBSD

initgroups(3): Fix return value on allocation failure
ClosedPublic

Authored by olce on Sep 16 2025, 5:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 19, 3:26 AM
Unknown Object (File)
Wed, Jul 15, 4:07 PM
Unknown Object (File)
Wed, Jul 15, 11:34 AM
Unknown Object (File)
Wed, Jul 15, 6:44 AM
Unknown Object (File)
Wed, Jul 15, 6:44 AM
Unknown Object (File)
Mon, Jul 13, 8:40 AM
Unknown Object (File)
Sun, Jul 12, 10:49 AM
Unknown Object (File)
Tue, Jun 30, 5:07 PM
Subscribers

Details

Summary

We must not return ENOMEM, but rather -1 with 'errno' set to ENOMEM, as
described in the manual page and as other implementations are doing.
A malloc() failure actually already sets ENOMEM for us. Add comments
indicating which function set 'errno' each time we return.

While here, improve style and remove useless headers.

Fixes: 54404cfb13d4 ("In preparation for raising NGROUPS and NGROUPS_MAX, ...")
MFC after: 1 week
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 67087
Build 63970: arc lint + arc unit

Event Timeline

olce requested review of this revision.Sep 16 2025, 5:11 PM
This revision is now accepted and ready to land.Sep 16 2025, 5:49 PM