Page MenuHomeFreeBSD

initgroups(3): Fix return value on allocation failure
ClosedPublic

Authored by olce on Sep 16 2025, 5:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 13, 5:18 AM
Unknown Object (File)
Mon, Oct 13, 2:51 AM
Unknown Object (File)
Sat, Oct 11, 4:41 AM
Unknown Object (File)
Sat, Oct 11, 4:41 AM
Unknown Object (File)
Sat, Oct 11, 4:41 AM
Unknown Object (File)
Fri, Oct 10, 9:33 PM
Unknown Object (File)
Thu, Oct 9, 9:35 PM
Unknown Object (File)
Wed, Oct 8, 12:00 PM
Subscribers

Details

Summary

We must not return ENOMEM, but rather -1 with 'errno' set to ENOMEM, as
described in the manual page and as other implementations are doing.
A malloc() failure actually already sets ENOMEM for us. Add comments
indicating which function set 'errno' each time we return.

While here, improve style and remove useless headers.

Fixes: 54404cfb13d4 ("In preparation for raising NGROUPS and NGROUPS_MAX, ...")
MFC after: 1 week
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce requested review of this revision.Sep 16 2025, 5:11 PM
This revision is now accepted and ready to land.Sep 16 2025, 5:49 PM