sound: Honor CHN_F_NBIO
ClosedPublic
Actions

Authored by christos on Sep 11 2025, 7:07 PM.

Details

Reviewers

markj
emaste
adrian

Commits

rG123881aead72: sound: Honor CHN_F_NBIO
rG0caba7093871: sound: Honor CHN_F_NBIO
rGe8b5025c3880: sound: Honor CHN_F_NBIO

Summary

If the device is opened with O_NONBLOCK, even though we check for it in
order to set CHN_F_NBIO, the subsequent chn_reset() calls will clear all
flags, except those set in CHN_F_RESET, which does not include
CHN_F_NBIO.

Add CHN_F_NBIO to CHN_F_RESET. Additionally, because primary channels
can be reused, make sure we do not unintentionally keep CHN_F_NBIO set
if the channel is re-opened, but without O_NONBLOCK.

PR: 289441
MFC after: 2 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 67042
Build 63925: arc lint + arc unit

Event Timeline

christos created this revision.Sep 11 2025, 7:07 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 11 2025, 7:07 PM

christos requested review of this revision.Sep 11 2025, 7:07 PM

Harbormaster completed remote builds in B66978: Diff 161926.Sep 11 2025, 7:07 PM

christos added a reviewer: adrian.Sep 12 2025, 3:02 PM

Do we need to clear CHN_F_NBIO in dsp_close() too?

In D52493#1199065, @markj wrote:

Do we need to clear CHN_F_NBIO in dsp_close() too?

So what the patch does should be enough since we always clear the flag on open(). Alternatively we could clear it only in dsp_close() only since all channels go through dsp_close(). I think the latter might be cleaner because we already clear flags there.

I agree, clearing CHN_F_NBIO in dsp_close() would be better. When debugging, if a closed channel has CHN_F_NBIO set, which then mysteriously disappears when it's re-opened, it could be confusing.

On https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289441 I've attached a patch that clears CHN_F_NBIO in dsp_close() instead (I don't seem to have permission to attach it to this revision directly).