Differential D52432

loader/efi: return error from efi_find_framebuffer
ClosedPublic
Actions

Authored by vexeduxr on Sep 8 2025, 9:04 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Feb 8, 5:09 AM

	Unknown Object (File)
	Sun, Feb 8, 4:18 AM

	Unknown Object (File)
	Sun, Feb 8, 1:46 AM

	Unknown Object (File)
	Sun, Feb 8, 1:20 AM

	Unknown Object (File)
	Sat, Feb 7, 9:29 PM

	Unknown Object (File)
	Sat, Jan 31, 2:36 PM

	Unknown Object (File)
	Dec 25 2025, 1:57 AM

	Unknown Object (File)
	Dec 3 2025, 10:27 PM

View All 45 Files

Subscribers

Details

Reviewers

imp
kevans
tsoome
jhb
manu

Commits

rGcd9b43edd5a7: loader/efi: return error from efi_find_framebuffer

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 66909
Build 63792: arc lint + arc unit

Event Timeline

vexeduxr created this revision.Sep 8 2025, 9:04 PM

Herald added a reviewer: manu. · View Herald TranscriptSep 8 2025, 9:04 PM

Herald added subscribers: dab, bcran. · View Herald Transcript

vexeduxr requested review of this revision.Sep 8 2025, 9:04 PM

Harbormaster completed remote builds in B66906: Diff 161744.Sep 8 2025, 9:04 PM

vexeduxr added a child revision: D52433: loader/efi: plug memory leak.Sep 8 2025, 9:04 PM

vexeduxr added a parent revision: D52431: loader/efi: build with -Wall.Sep 8 2025, 9:05 PM

Remove redundant initialization

Harbormaster completed remote builds in B66909: Diff 161747.Sep 8 2025, 9:13 PM

If you do not mind to do extra work, the function is supposed to return 0 or error code, could you replace the return(1) lines above with return (efi_status_to_errno(status)) or like:)

This revision is now accepted and ready to land.Sep 9 2025, 6:49 AM

Ah, I don't mind. :)

Return actual errno values in other code paths.

This revision now requires review to proceed.Sep 9 2025, 11:08 AM

Harbormaster completed remote builds in B66917: Diff 161779.Sep 9 2025, 11:08 AM

thanks!

This revision is now accepted and ready to land.Sep 9 2025, 2:09 PM

imp accepted this revision.Sep 9 2025, 2:10 PM

Closed by commit rGcd9b43edd5a7: loader/efi: return error from efi_find_framebuffer (authored by vexeduxr). · Explain WhySep 9 2025, 5:31 PM

This revision was automatically updated to reflect the committed changes.

vexeduxr added a commit: rGcd9b43edd5a7: loader/efi: return error from efi_find_framebuffer.

Revision Contents
Changeset List

Path

Size

stand/

efi/

loader/

3 lines

Diff 161747

stand/efi/loader/framebuffer.c

Loading...