Page MenuHomeFreeBSD
Differential D52062

sys/modules: fix standalone build for multiple build
ClosedPublic
Actions

Authored by aokblast on Aug 21 2025, 8:28 AM.
Tags
None
Referenced Files
F164681749: D52062.diff
Mon, Aug 3, 3:50 AM
Unknown Object (File)
Sun, Aug 2, 3:10 PM
Unknown Object (File)
Sun, Aug 2, 3:09 PM
Unknown Object (File)
Thu, Jul 30, 2:44 PM
Unknown Object (File)
Thu, Jul 30, 7:24 AM
Unknown Object (File)
Tue, Jul 28, 11:58 PM
Unknown Object (File)
Thu, Jul 23, 1:35 AM
Unknown Object (File)
Tue, Jul 21, 12:38 AM
View All 79 Files
Subscribers
donner
imp

Details

Reviewers
lwhsu
markj
Commits
rG2890e164f15b: sys/modules: fix standalone build for multiple modules
rG8a847947153e: sys/modules: fix standalone build for multiple modules
Summary

Multiple Makefile miss opt_*.h and *_if.h header file. We fix it by
running `make` in sys/modules to build all modules.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

aokblast created this revision.Aug 21 2025, 8:28 AM
Herald added subscribers: donner, imp. · View Herald TranscriptAug 21 2025, 8:28 AM
aokblast requested review of this revision.Aug 21 2025, 8:28 AM
Harbormaster completed remote builds in B66399: Diff 160712.Aug 21 2025, 8:28 AM
aokblast added reviewers: lwhsu, markj.Aug 21 2025, 8:29 AM
aokblast updated this revision to Diff 160713.Aug 21 2025, 8:32 AM

formatting

Harbormaster completed remote builds in B66400: Diff 160713.Aug 21 2025, 8:32 AM
lwhsu accepted this revision.Aug 21 2025, 8:33 AM

I believe you mean “multiple modules”

This revision is now accepted and ready to land.Aug 21 2025, 8:33 AM
markj added a comment.Aug 22 2025, 1:04 PM

How exactly did you test it? Remove the object directory first and then make sys/modules?

In D52062#1189371, @lwhsu wrote:

I believe you mean “multiple modules”

+1

Closed by commit rG8a847947153e: sys/modules: fix standalone build for multiple modules (authored by aokblast). · Explain WhyAug 23 2025, 5:00 AM
This revision was automatically updated to reflect the committed changes.
aokblast added a commit: rG8a847947153e: sys/modules: fix standalone build for multiple modules.
zlei added a reverting change: D54889: qlnxev: Remove now unneeded include for opt_inet.h.Jan 26 2026, 6:43 AM
zlei added a commit: rG2890e164f15b: sys/modules: fix standalone build for multiple modules.Jan 26 2026, 10:09 AM
zlei added a reverting change: rGec7950fe4234: qlnxev: Remove now unneeded include for opt_inet.h.Feb 6 2026, 6:00 PM
zlei added a reverting change: rG926e44b49834: qlnxev: Remove now unneeded include for opt_inet.h.Feb 11 2026, 10:03 AM
zlei added a reverting change: rGe1a051fd53a0: qlnxev: Remove now unneeded include for opt_inet.h.Feb 11 2026, 1:49 PM
cperciva added a reverting change: rG133eae6afd60: qlnxev: Remove now unneeded include for opt_inet.h.Feb 11 2026, 8:30 PM

Revision Contents
Changeset List

PathSize
sys/
modules/
e6000sw/
2 lines
etherswitch/
2 lines
evdev/
2 lines
gpio/
gpioaei/
2 lines
gve/
2 lines
if_infiniband/
3 lines
if_vlan/
2 lines
linux64/
1 line
md/
2 lines
miiproxy/
2 lines
mlx5/
2 lines
mlx5en/
2 lines
netgraph/
ksocket/
2 lines
nvmf/
nvmf/
3 lines
qlnx/
qlnxev/
1 line
uinput/
2 lines
usb/
usie/
2 lines
wmt/
2 lines

Diff 160871

View Options

sys/modules/e6000sw/Makefile

Loading...
View Options

sys/modules/etherswitch/Makefile

Loading...
View Options

sys/modules/evdev/Makefile

Loading...
View Options

sys/modules/gpio/gpioaei/Makefile

Loading...
View Options

sys/modules/gve/Makefile

Loading...
View Options

sys/modules/if_infiniband/Makefile

Loading...
View Options

sys/modules/if_vlan/Makefile

Loading...
View Options

sys/modules/linux64/Makefile

Loading...
View Options

sys/modules/md/Makefile

Loading...
View Options

sys/modules/miiproxy/Makefile

Loading...
View Options

sys/modules/mlx5/Makefile

Loading...
View Options

sys/modules/mlx5en/Makefile

Loading...
View Options

sys/modules/netgraph/ksocket/Makefile

Loading...
View Options

sys/modules/nvmf/nvmf/Makefile

Loading...
View Options

sys/modules/qlnx/qlnxev/Makefile

Loading...
View Options

sys/modules/uinput/Makefile

Loading...
View Options

sys/modules/usb/usie/Makefile

Loading...
View Options

sys/modules/usb/wmt/Makefile

Loading...