In case it isn't obvious, we can't stub or #ifdef this in libsa since that is presumably shared by all loaders for a given arch, thus a non-optional src from loader.mk would seem to make sense - misc.c seemed as good as any?

des accepted this revision.Thu, Aug 21, 7:07 AM

des added a subscriber: des.

des added inline comments.

stand/common/misc.c
224	maybe add an explanatory comment here

This revision is now accepted and ready to land.Thu, Aug 21, 7:07 AM

In D52060#1189324, @sjg wrote:

In case it isn't obvious, we can't stub or #ifdef this in libsa since that is presumably shared by all loaders for a given arch, thus a non-optional src from loader.mk would seem to make sense - misc.c seemed as good as any?

Let's just get this in and we can debate it later, but I note that this could have been a __weak_symbol in libsa.

kevans accepted this revision.Thu, Aug 21, 3:06 PM

let's not gild this too much. I plan on removing this stupid hack when I have a reasonable alternative. It's only here for 15.0. The real fix is to remove the need for it completely.

Closed by commit rG027be99b1f33: Stub is_tftp when LOADER_NET_SUPPORT is not enabled (authored by sjg). · Explain WhyThu, Aug 21, 3:11 PM

This revision was automatically updated to reflect the committed changes.

sjg added a commit: rG027be99b1f33: Stub is_tftp when LOADER_NET_SUPPORT is not enabled.