Page MenuHomeFreeBSD
Differential D52062

sys/modules: fix standalone build for multiple build
ClosedPublic
Actions

Authored by aokblast on Thu, Aug 21, 8:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Aug 31, 3:24 PM
Unknown Object (File)
Tue, Aug 26, 6:18 PM
Unknown Object (File)
Tue, Aug 26, 4:44 AM
Unknown Object (File)
Tue, Aug 26, 1:04 AM
Unknown Object (File)
Mon, Aug 25, 7:14 PM
Unknown Object (File)
Mon, Aug 25, 11:59 AM
Unknown Object (File)
Mon, Aug 25, 11:44 AM
Unknown Object (File)
Mon, Aug 25, 11:03 AM
View All 10 Files
Subscribers
donner
imp

Details

Reviewers
lwhsu
markj
Commits
rG8a847947153e: sys/modules: fix standalone build for multiple modules
Summary

Multiple Makefile miss opt_*.h and *_if.h header file. We fix it by
running `make` in sys/modules to build all modules.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 66400
Build 63283: arc lint + arc unit

Event Timeline

aokblast created this revision.Thu, Aug 21, 8:28 AM
Herald added subscribers: donner, imp. · View Herald TranscriptThu, Aug 21, 8:28 AM
aokblast requested review of this revision.Thu, Aug 21, 8:28 AM
Harbormaster completed remote builds in B66399: Diff 160712.Thu, Aug 21, 8:28 AM
aokblast added reviewers: lwhsu, markj.Thu, Aug 21, 8:29 AM
aokblast updated this revision to Diff 160713.Thu, Aug 21, 8:32 AM

formatting

Harbormaster completed remote builds in B66400: Diff 160713.Thu, Aug 21, 8:32 AM
lwhsu accepted this revision.Thu, Aug 21, 8:33 AM

I believe you mean “multiple modules”

This revision is now accepted and ready to land.Thu, Aug 21, 8:33 AM
markj added a comment.Fri, Aug 22, 1:04 PM

How exactly did you test it? Remove the object directory first and then make sys/modules?

In D52062#1189371, @lwhsu wrote:

I believe you mean “multiple modules”

+1

Closed by commit rG8a847947153e: sys/modules: fix standalone build for multiple modules (authored by aokblast). · Explain WhySat, Aug 23, 5:00 AM
This revision was automatically updated to reflect the committed changes.
aokblast added a commit: rG8a847947153e: sys/modules: fix standalone build for multiple modules.

Revision Contents
Changeset List

PathSize
sys/
modules/
e6000sw/
2 lines
etherswitch/
2 lines
evdev/
2 lines
gpio/
gpioaei/
2 lines
gve/
2 lines
if_infiniband/
3 lines
if_vlan/
2 lines
linux64/
1 line
md/
2 lines
miiproxy/
2 lines
mlx5/
2 lines
mlx5en/
2 lines
netgraph/
ksocket/
2 lines
nvmf/
nvmf/
3 lines
qlnx/
qlnxev/
1 line
uinput/
2 lines
usb/
usie/
2 lines
wmt/
2 lines

Diff 160713

View Options

sys/modules/e6000sw/Makefile

Loading...
View Options

sys/modules/etherswitch/Makefile

Loading...
View Options

sys/modules/evdev/Makefile

Loading...
View Options

sys/modules/gpio/gpioaei/Makefile

Loading...
View Options

sys/modules/gve/Makefile

Loading...
View Options

sys/modules/if_infiniband/Makefile

Loading...
View Options

sys/modules/if_vlan/Makefile

Loading...
View Options

sys/modules/linux64/Makefile

Loading...
View Options

sys/modules/md/Makefile

Loading...
View Options

sys/modules/miiproxy/Makefile

Loading...
View Options

sys/modules/mlx5/Makefile

Loading...
View Options

sys/modules/mlx5en/Makefile

Loading...
View Options

sys/modules/netgraph/ksocket/Makefile

Loading...
View Options

sys/modules/nvmf/nvmf/Makefile

Loading...
View Options

sys/modules/qlnx/qlnxev/Makefile

Loading...
View Options

sys/modules/uinput/Makefile

Loading...
View Options

sys/modules/usb/usie/Makefile

Loading...
View Options

sys/modules/usb/wmt/Makefile

Loading...