Differential D51954

zfs: Set st_rdev to NODEV, not 0, when not a device
ClosedPublic
Actions

Authored by des on Aug 17 2025, 3:54 PM.

Details

Reviewers

kib
mm

Commits

rGccc7f2f20238: zfs: Set st_rdev to NODEV, not 0, when not a device

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 66305
Build 63188: arc lint + arc unit

Event Timeline

des created this revision.Aug 17 2025, 3:54 PM

Herald added subscribers: delphij, imp. · View Herald TranscriptAug 17 2025, 3:54 PM

des requested review of this revision.Aug 17 2025, 3:54 PM

Harbormaster completed remote builds in B66305: Diff 160469.Aug 17 2025, 3:54 PM

des added a child revision: D51956: vfs: Assert that st_rdev is NODEV for non-devices.Aug 17 2025, 3:56 PM

kib accepted this revision.Aug 17 2025, 4:17 PM

This revision is now accepted and ready to land.Aug 17 2025, 4:17 PM

sys/contrib/openzfs/module/os/freebsd/zfs/zfs_ctldir.c
497:    vap->va_rdev = 0;

This revision now requires review to proceed.Aug 17 2025, 4:44 PM

Harbormaster completed remote builds in B66310: Diff 160476.Aug 17 2025, 4:44 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 17 2025, 5:31 PM

Closed by commit rGccc7f2f20238: zfs: Set st_rdev to NODEV, not 0, when not a device (authored by des). · Explain Why

This revision was automatically updated to reflect the committed changes.

des added a commit: rGccc7f2f20238: zfs: Set st_rdev to NODEV, not 0, when not a device.

Revision Contents
Changeset List

Path

Size

sys/

contrib/

openzfs/

module/

os/

freebsd/

zfs/

zfs_vnops_os.c

2 lines

Diff 160469

View Options

sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c

zfs: Set st_rdev to NODEV, not 0, when not a deviceClosedPublicActions